1801585 - Crash in [@ mozilla::gl::AndroidSharedBlitGL::~AndroidSharedBlitGL]

Status: REOPENED

(Core :: Graphics, defect, P5)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/9050afea-b636-4296-a75a-2c9de0221117

Looks like sContent might be NULL in https://hg.mozilla.org/mozilla-central/file/c6fc40e2f3b118dd3bee9ca6ef807b91813e4b68/gfx/gl/AndroidSurfaceTexture.cpp#l46.

The earliest crash report was from Fenix 106.1.0.

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0  libxul.so  std::__ndk1::shared_ptr<mozilla::gl::EglDisplay>::operator* const  /builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/memory:3803
0  libxul.so  mozilla::gl::AndroidSharedBlitGL::~AndroidSharedBlitGL  gfx/gl/AndroidSurfaceTexture.cpp:46
0  libxul.so  mozilla::DefaultDelete<mozilla::gl::AndroidSharedBlitGL>::operator const  mfbt/UniquePtr.h:459
0  libxul.so  mozilla::UniquePtr<mozilla::gl::AndroidSharedBlitGL, mozilla::DefaultDelete<mozilla::gl::AndroidSharedBlitGL> >::reset  mfbt/UniquePtr.h:301
0  libxul.so  mozilla::UniquePtr<mozilla::gl::AndroidSharedBlitGL, mozilla::DefaultDelete<mozilla::gl::AndroidSharedBlitGL> >::~UniquePtr  mfbt/UniquePtr.h:249
0  libxul.so  mozilla::gl::GLBlitterSupport::~GLBlitterSupport  gfx/gl/AndroidSurfaceTexture.cpp:150
0  libxul.so  mozilla::DefaultDelete<mozilla::gl::GLBlitterSupport>::operator const  mfbt/UniquePtr.h:459
1  libxul.so  mozilla::jni::NativeImpl<mozilla::java::GeckoSurfaceTexture::NativeGLBlitHelper, mozilla::gl::GLBlitterSupport>::DisposeNative  widget/android/jni/Natives.h:1607
1  libxul.so  mozilla::jni::NativeStub<mozilla::java::GeckoSurfaceTexture::NativeGLBlitHelper::DisposeNative_t, mozilla::gl::GLBlitterSupport, mozilla::jni::Args<> >::Wrap<&mozilla::jni::NativeImpl<mozilla::java::GeckoSurfaceTexture::NativeGLBlitHelper, mozilla::gl::GLBlitterSupport>::DisposeNative  widget/android/jni/Natives.h:1489
2  base.odex  base.odex@0x5b2db  

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1801585 - Improve error handling in AndroidSharedBlitGL.

This patch logs errors in allocating a GL context and target surface for
AndroidSharedBlitGL to the gfx critical log, so that it will show up in
any crash reports and about:support. It also more gracefully handles
these errors to avoid prematurely freeing the shared GL context, if any.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c3e7ab21165e
https://hg.mozilla.org/integration/autoland/rev/2c138780f42c
Improve error handling in AndroidSharedBlitGL. r=jolin

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2c138780f42c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9a40eadb5e11
https://hg.mozilla.org/integration/autoland/rev/7ca5cf8f09d9
Revert "Bug 1801585 - Improve error handling in AndroidSharedBlitGL. r=jolin" on request by aosmond for causing bug 1982848

Comment 5

[Cristina Horotan [:chorotan]]

Backed out here: https://hg.mozilla.org/integration/autoland/rev/7ca5cf8f09d9f146962213e94b3ce7d8a735320f

Comment 6

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg-edge.mozilla.org/mozilla-central/rev/7ca5cf8f09d9