1801607 - Certificate Manager table too high

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[David Balažic]

Attachment: ff_cert_view.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

update from v106 to v107
open "about:preferences"
Certificates , click "View Certificates..."

Actual results:

the table showing certificates is way too tall, the button on the bottom are visible only after scrolling down

Expected results:

Same as in V106, normal layout

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[David Shin[:dshin]]

I've added some custom certificates for testing on my setup on Windows 10 on v107 but I am unable to reproduce this.
Have you tried this with a fresh profile? (I suppose with your certificates re-imported)

Comment 3

[Blake]

(In reply to David Shin[:dshin] from comment #2)

I've added some custom certificates for testing on my setup on Windows 10 on v107 but I am unable to reproduce this.
Have you tried this with a fresh profile? (I suppose with your certificates re-imported)

Is there an easy way to export all certificates? I see the same issue where the "Your Certificates" has a large blank, but scrollable area. It seems like every section share the same length.

Comment 4

[David Shin[:dshin]]

(In reply to Blake from comment #3)

(In reply to David Shin[:dshin] from comment #2)

I've added some custom certificates for testing on my setup on Windows 10 on v107 but I am unable to reproduce this.
Have you tried this with a fresh profile? (I suppose with your certificates re-imported)

Is there an easy way to export all certificates? I see the same issue where the "Your Certificates" has a large blank, but scrollable area. It seems like every section share the same length.

If you Ctrl select the certificates (Not the org names) and click "Export," it pops up one save dialog for each selected certificate.

Comment 5

[Blake]

(In reply to David Shin[:dshin] from comment #4)

(In reply to Blake from comment #3)

(In reply to David Shin[:dshin] from comment #2)

I've added some custom certificates for testing on my setup on Windows 10 on v107 but I am unable to reproduce this.
Have you tried this with a fresh profile? (I suppose with your certificates re-imported)

Is there an easy way to export all certificates? I see the same issue where the "Your Certificates" has a large blank, but scrollable area. It seems like every section share the same length.

If you Ctrl select the certificates (Not the org names) and click "Export," it pops up one save dialog for each selected certificate.

I'm getting "Failed to create PKCS #12 backup file for unknown reasons" when trying to export a certificate. The "Servers" section will also not let me select multiple ones.

Comment 6

[David Balažic]

(In reply to David Shin[:dshin] from comment #2)

I've added some custom certificates for testing on my setup on Windows 10 on v107 but I am unable to reproduce this.
Have you tried this with a fresh profile? (I suppose with your certificates re-imported)

Does not happen in a fresh profile.

I noticed this: the dialog height minimum (actually the minimum height of some element in it) is set to match the "Servers" tab height.
IOW: the Servers tab can be scrolled from top to bottom by the single scrollbar, while other tabs with longer lists (like the "Authorities") have two nested vertical scroll bars, and tabs with shorter list (like "Your Certificates") are stretched out (the table has many empty lines below the normal entries) and needs to be scrolled.

I guess you can reproduce the issue by filling the "Servers" tab with many entries (i.e. visit a website with invalid certificate, clik "open website anyway and add it to the list", repeat).

Comment 7

[David Shin[:dshin]]

(In reply to Blake from comment #5)

I'm getting "Failed to create PKCS #12 backup file for unknown reasons" when trying to export a certificate. The "Servers" section will also not let me select multiple ones.

Likely managed by the OS as per bug 374845 comment 18.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

I was able to reproduce this using the DevTools to artificially inflate the number of items in the servers list by duplicating the richlistitems that already exist in there.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Here are some (maybe) STR that might help us find a regression range:

1. Open about:preferences
2. Choose the Privacy & Security pane and scroll down to the "View Certificates" button
3. Click the "View Certificates" button to open the certificate manager dialog
4. Click on the "Servers" tab
5. Open the page devtools (Ctrl-Shift-K / Cmd-Shift-K)
6. In the console, paste this code in and press enter:

let serverList = gSubDialog._dialogs[0]._frame.contentDocument.querySelector("#serverList"); 
serverList.style.height = "500px";

ER:

The dialog should not stretch such that it becomes unusable.

AR:

The dialog gets taller to the point where it stretches outside of the bounds of the content area.

Comment 10

[Blake]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #9)

Here are some (maybe) STR that might help us find a regression range:

1. Open about:preferences
2. Choose the Privacy & Security pane and scroll down to the "View Certificates" button
3. Click the "View Certificates" button to open the certificate manager dialog
4. Click on the "Servers" tab
5. Open the page devtools (Ctrl-Shift-K / Cmd-Shift-K)
6. In the console, paste this code in and press enter:

let serverList = gSubDialog._dialogs[0]._frame.contentDocument.querySelector("#serverList"); 
serverList.style.height = "500px";

ER:

The dialog should not stretch such that it becomes unusable.

AR:

The dialog gets taller to the point where it stretches outside of the bounds of the content area.

With these steps, mozregressions points to Bug 1689816.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1689816, could you take a look?

For more information, please visit auto_nag documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1801607 - Improve certManager layout. r=mconley

Allow the tabbox/tabpanels to shrink, and remove an useless <vbox>.

Comment 13

[Rares Doghi, Desktop QA]

I was also able to reproduce this issue using the steps from Comment 9, Thanks Mike ! Updating the flags for this issue.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Better and more realistic STR:

1. Open about:preferences
2. Choose the Privacy & Security pane and scroll down to the "View Certificates" button
3. Click the "View Certificates" button to open the certificate manager dialog
4. Click on the "Servers" tab
5. Open the page devtools (Ctrl-Shift-K / Cmd-Shift-K)
6. In the console, paste this code in and press enter:

let serverList = gSubDialog._dialogs[0]._frame.contentDocument.querySelector("#serverList"); 
for (let i = 0; i < 100; ++i) {
  let item = document.createXULElement("richlistitem");
  let content = document.createElement("div");
  content.textContent = `Row ${i}`;
  item.appendChild(content);
  serverList.appendChild(item);
}

ER:

The dialog should not stretch such that it becomes unusable.

AR:

The dialog gets taller to the point where it stretches outside of the bounds of the content area.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

That's not great, because the dialog opening code takes measurements of the initial contents to size the dialog. What I did to debug / repro this is going to https://badssl.com, clicking on all the links, and add exceptions for the ones I could. That should leave you with around 40 exceptions in the list which should be enough to reproduce the issue.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Dao is the current version of the patch fine for you?

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1689816

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9471fe1c5c47
Improve certManager layout. r=mconley,settings-reviewers

Comment 19

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9471fe1c5c47

Comment 21

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 110.0a1 (2022-12-20).

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 24

[Rares Doghi, Desktop QA]

Updating the Main Status flags for this issue.