MOZ_APP_DISPLAYNAME doesn't have the expected behaviour
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
People
(Reporter: mce-berte.consultant, Unassigned)
Details
Steps to reproduce:
I tried to fix MOZ_APP_DISPLAYNAME in the mozconfig file to define the custom name of my build.
Actual results:
In the about Windows, it says "about Thunderbird" and "Thunderbird is up to date"
Expected results:
I expected that in the "about window" as well as everywhere else in the software, "Thunderbird" would be replaced by "My Custom Name", set in the MOZ_APP_DISPLAYNAME variable. I have no idea how I can customize these aspects.
|
||
Comment 1•3 years ago
|
||
Rob might know more - sounds reasonable that the same custom MOZ_APP_DISPLAYNAME should be used all over if we allow customizing that...?
https://searchfox.org/comm-central/search?path=&q=MOZ_APP_DISPLAYNAME
|
||
Comment 2•3 years ago
|
||
Only changing the variable certainly won't be enough. You'd need to change at least brand.dtd and branding.nsi
|
Reporter | |
Comment 3•3 years ago
|
||
I managed to do what I wanted to do changing brand.properties, brand.ftl and brand.dtd in the l10n-base, but I have the feeling that it's not the right way to do it, because I can't use this to modifying things like images for example.
|
|
||
Comment 4•3 years ago
|
||
Change MOZ_BRANDING_DIRECTORY perhaps?
|
||
Comment 5•3 years ago
|
||
MOZ_APP_DISPLAYNAME should only be used for static user-visible fields (e.g., DLL properties, Mac Bundle name, or similar). If you're displaying in the UI, a (theoretically) localized string from the brand.* files is used. In practice, the only string from those files that really gets translated is the trademark info string. The others are all Brand names which are not translated (mostly).
As Magnus suggested, creating your own directory under /comm/mail/branding and then using it with ac_add_options --with-branding=comm/mail/branding/custom will get you the results you are looking for. MOZ_APP_DISPLAYNAME is set in configure.sh. In the locales subdirectory you will find the en-US versions of the brand.* files you edited. The images used in the About Dialog are in there as well.
Side note... if you copy nightly branding, you will not have to create different versions for all of the locales you want to support with your build. The brand.* strings files for en-US are used regardless of the actual locale you might be packaging.
And setting MOZ_APP_DISPLAYNAME in mozconfig doesn't work because it's processed before the branding configure.sh files.
Description
•