Closed
Bug 1801674
Opened 1 year ago
Closed 1 year ago
Annotate in AsyncShutdown metadata if some blocker could not be added
Categories
(Toolkit :: Async Tooling, defect, P2)
Toolkit
Async Tooling
Tracking
()
RESOLVED
FIXED
109 Branch
| Tracking | Status | |
|---|---|---|
| firefox109 | --- | fixed |
People
(Reporter: mak, Assigned: Gijs)
References
Details
Attachments
(1 file)
In cases like Bug 1795687, we failed to add a blocker, and because of that we failed to unblock a barrier (the blocker itself contains code to unblock the barrier) but in the metadata that fact is completely missing.
The consumers may not be coding defensively against a failing addBlocker call (common: I init things, then I add blocker to uninit them).
There are various clear points of failure, where we may fail adding a blocker, for example:
https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/toolkit/components/asyncshutdown/AsyncShutdown.jsm#697-706,776
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2316c7f19545 add broken addBlocker calls into crash report metadata and logs, r=gsvelto,mak
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•