1801696 - Running `install-certificate` prompts user twice if there is no existing token

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P3)

Description

[Zeid Zabaneh [:zeid]]

STR:

Expected behaviour:

• run moz-phab install-certificate
• get prompted to enter API token
• enter API token
• return to shell prompt

Actual behaviour:

• run moz-phab install-certificate
• moz-phab prompts use to enter API token saying that "No API token detected, running install-certificate"
• user enters token
• user gets prompted again to enter API token, this time presumably as part of running the original command.

Potential fix:

• detect that the user is trying to install token, thus skip the check for existing token.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: mozphab: avoid auto-run of `install-certificate` if we are already running it (Bug 1801696) r?zeid

Move loading of the Conduit API token to a function. Add a
conditional to avoid loading the token or auto-running
install-certificate when the user has explicitly run
that command.