Closed Bug 1801767 Opened 1 year ago Closed 1 year ago

Remove fs::remove_dir_all usage in remove_disk_cache()

Categories

(Core :: Graphics: WebRender, task)

task

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox108 --- fixed
firefox109 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

From Bug 1799442, fs::remove_dir_all is not stable on Windows. It needs to be replaced like Bug 1799442.

Blocks: 1799442
Assignee: nobody → sotaro.ikeda.g
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2f2270d30e2
Remove fs::remove_dir_all usage in remove_disk_cache() r=gfx-reviewers,bradwerth
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

When I do a (clobber?) build of the JS shell, I now get Cargo.lock changes because something is sorting the dependencies list for me. Can we fix this? :)

  "objc",
  "rayon",
+ "remove_dir_all",
  "swgl",
  "thin-vec",
  "tracy-rs",
  "uuid",
  "webrender",
  "winapi",
  "wr_malloc_size_of",
- "remove_dir_all",
 ]
Flags: needinfo?(sotaro.ikeda.g)

(In reply to Jan de Mooij [:jandem] from comment #4)

When I do a (clobber?) build of the JS shell, I now get Cargo.lock changes because something is sorting the dependencies list for me. Can we fix this? :)

  "objc",
  "rayon",
+ "remove_dir_all",
  "swgl",
  "thin-vec",
  "tracy-rs",
  "uuid",
  "webrender",
  "winapi",
  "wr_malloc_size_of",
- "remove_dir_all",
 ]

"cargo update --workspace" reproduced it for me. I am going to update it.

Flags: needinfo?(sotaro.ikeda.g)
Blocks: 1802388
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: