In a bug with many attachments, it is hard to quickly scan for attachments that have "review+". It looks so much alike to "review-". Even in bugs with few patches, it is difficult for some to differentiate the two. Take for example bug 173094 which was just checked in with r=timeless. However, the patch has "timeless: review-" I propose using color coding: something like red for "-" flags, green for "+" flags, and possibly grey for "?" flags.
This works: <select name="test" size="1" style="background-color: white" onchange="this.style.backgroundColor = this.options[this.selectedIndex].style.backgroundColor"> <option value=" " style="background-color: white"> </option> <option value="-" style="background-color: red">-</option> <option value="+" style="background-color: green">+</option> <option value="?" style="background-color: gray">?</option> </select> Except if something besides " " is already selected when it loads, it doesn't propogate the background color...
In bug 178852, we mention that flags are difficult for accessibility, so marking this one as a blocker of that bug.