1802075 - Spurious "/bin/sh: 1: --stop-server: not found" at the end of logs after a failure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Example output from mach build:

 0:04.91 gmake[2]: *** [/mozilla-unified/config/recurse.mk:34: export] Error 2
 0:04.91 gmake[1]: *** [/mozilla-unified/config/rules.mk:361: default] Error 2
 0:04.91 /bin/sh: 1: --stop-server: not found
 0:04.91 gmake: *** [client.mk:58: build] Error 2

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1802075 - Avoid calling "--stop-server" as a command on local build failure.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1798779

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cd8e3c7fa88
Avoid calling "--stop-server" as a command on local build failure. r=firefox-build-system-reviewers,andi

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3cd8e3c7fa88

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 9304858 [details]
Bug 1802075 - Avoid calling "--stop-server" as a command on local build failure.

Beta/Release Uplift Approval Request

• User impact if declined: Unrelated error message printed on build failure.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9304858 [details]
Bug 1802075 - Avoid calling "--stop-server" as a command on local build failure.

Approved for 108.0b7.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ae8bfb37384