Closed Bug 1802089 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 37099 - Avoid decode race when checking powerEfficientDecode stat

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37099 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37099
Details from upstream follow.

Evan Shrubsole <eshr@google.com> wrote:

Avoid decode race when checking powerEfficientDecode stat

The previous code only waited for packets sent and received but this
could result in a race condition for the powerEfficientDecode stat as
the received video frame may not have finished decoding yet.

Bug: 1392850
Change-Id: I9d59b5e88e144f2b92a15fe70b8d1d1abfb85fa3
Reviewed-on: https://chromium-review.googlesource.com/4047405
WPT-Export-Revision: 88b021bbf17f60b8467a68fb0ee31a989c222128

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
FAIL: 12

Chrome

OK : 1
PASS: 12

Safari

OK : 1
PASS: 4
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /webrtc-stats/hardware-capability-stats.https.html [wpt.fyi]
    • powerEfficientEncoder not exposed when not capturing or fullscreen.: FAIL
    • encoderImplementation not exposed when not capturing or fullscreen.: FAIL
    • powerEfficientDecoder not exposed when not capturing or fullscreen.: FAIL
    • decoderImplementation not exposed when not capturing or fullscreen.: FAIL

New Tests That Don't Pass

  • /webrtc-stats/hardware-capability-stats.https.html [wpt.fyi]
    • powerEfficientEncoder not exposed when not capturing or fullscreen.: FAIL (Chrome: PASS, Safari: PASS)
    • powerEfficientEncoder exposed when fullscreen.: FAIL (Chrome: PASS, Safari: FAIL)
    • powerEfficientEncoder exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
    • encoderImplementation not exposed when not capturing or fullscreen.: FAIL (Chrome: PASS, Safari: PASS)
    • encoderImplementation exposed when fullscreen.: FAIL (Chrome: PASS, Safari: FAIL)
    • encoderImplementation exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
    • powerEfficientDecoder not exposed when not capturing or fullscreen.: FAIL (Chrome: PASS, Safari: PASS)
    • powerEfficientDecoder exposed when fullscreen.: FAIL (Chrome: PASS, Safari: FAIL)
    • powerEfficientDecoder exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
    • decoderImplementation not exposed when not capturing or fullscreen.: FAIL (Chrome: PASS, Safari: PASS)
    • decoderImplementation exposed when fullscreen.: FAIL (Chrome: PASS, Safari: FAIL)
    • decoderImplementation exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59b484ca9ad6 [wpt PR 37099] - Avoid decode race when checking powerEfficientDecode stat, a=testonly

https://hg.mozilla.org/mozilla-central/rev/59b484ca9ad6

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.