18021 - Use nsSpecialSystemDirectory class to get temporary directory

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Michael Lowe]

The files:

1. mimedrft.cpp
2. nsEmitterUtils.cpp

should use the class "nsSpecialSystemDirectory"
instead of the function "GetTheTempDirectoryOnTheSystem" to get the temporary
directory.

Comment 1

[rhp (gone)]

Feel free to jump in if you would like :-)

- rhp

Comment 2

[phil]

Vaguely related to that would be the possibility not to use the system temp
directory. Instead the cache directory could be used (uppon user's choice) or a
different one.
Philippe Maestri

Comment 3

[rhp (gone)]

*** Bug 19182 has been marked as a duplicate of this bug. ***

Comment 4

[rhp (gone)]

Made these changes...will checkin when the tree opens.

- rhp

Comment 5

[rhp (gone)]

Should be fixed now.

- rhp

Comment 6

[Michael Lowe]

Some more instances you might like to fix:

/mailnews/compose/tests/compose2/test2.cpp
/mailnews/mapi/hook/mapihook.cpp
/mailnews/mapi/mapi32/mapiutl.cpp

Comment 7

[rhp (gone)]

Thanks for the comments, but mozilla\mailnews\mapi is a Windows only MAPI DLL
so the calls would equate to the same and the other is a test harness program
and I'm sort of swamped with bugs to fix those, verify on 3 platforms, etc..
:-)

- rhp

Comment 8

[ppandit]

Current mozilla text search for GetTheTempDirectoryOnTheSystem shows:
/mailnews/compose/tests/compose2/test2.cpp, line 90 --
GetTheTempDirectoryOnTheSystem(void)
/mailnews/compose/tests/compose2/test2.cpp, line 164 -- char *tDir =
GetTheTempDirectoryOnTheSystem();
/mailnews/mapi/hook/mapihook.cpp, line 1096 --
GetTheTempDirectoryOnTheSystem(void)
/mailnews/mapi/hook/mapihook.cpp, line 1151 -- LPSTR szTempPath =
GetTheTempDirectoryOnTheSystem();
/mailnews/mapi/mapi32/mapiutl.cpp, line 330 --
GetTheTempDirectoryOnTheSystem(void)
/mailnews/mapi/mapi32/mapiutl.cpp, line 369 -- LPSTR szTempPath =
GetTheTempDirectoryOnTheSystem();
/mailnews/mapi/mapi32/mapiutl.cpp, line 657 -- char *szTempPath =
GetTheTempDirectoryOnTheSystem();

Current search for nsSpecialSystemDirectory shows:
/mailnews/mime/emitters/src/nsEmitterUtils.cpp, line 34 -- #include
"nsSpecialSystemDirectory.h"
/mailnews/mime/emitters/src/nsEmitterUtils.cpp, line 100 -- nsFileSpec *tmpSpec
= new
nsFileSpec(nsSpecialSystemDirectory(nsSpecialSystemDirectory::OS_TemporaryDirect
ory));
/mailnews/mime/emitters/src/nsEmitterUtils.cpp, line 121 -- nsFileSpec *tmpSpec
= new
nsFileSpec(nsSpecialSystemDirectory(nsSpecialSystemDirectory::OS_TemporaryDirect
ory));
/mailnews/mime/src/mimedrft.cpp, line 49 -- #include
"nsSpecialSystemDirectory.h"
/mailnews/mime/src/mimedrft.cpp, line 115 -- nsFileSpec *tmpSpec = new
nsFileSpec(nsSpecialSystemDirectory(nsSpecialSystemDirectory::OS_TemporaryDirect
ory));

VERIFIED