1802122 - Avoid sending Form History autocomplete preference values across content to main process boundaries

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Mark Banner (:standard8)]

In bug 1697392 we are looking to use FormHistory.getAutoCompleteResults directly from the search suggestion code.

When trying that out, I realised that we would need to pass a set of parameters that are obtained from preferences.

Digging a bit more, I realised that these parameters are never modified by the code - we load/cache them in the content process (assuming a separate content process), and then forward them across to the main process.

We can simplify this by having Prefs within FormHistory.jsm cache the preferences and then getAutoCompleteResults can use them directly.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1802122 - Avoid sending Form History autocomplete preference values across the content to mainProcess boundaries. r?#credential-management-reviewers!

These are currently loaded from prefs in the content process, and then passed to the main process
without modification. To simplify this, we can load and manage these directly in FormHistory.

This also allows FormHistory.getAutoCompleteResults() to be called directly, without having to
replicate all the preferences.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24dd86b49420
Avoid sending Form History autocomplete preference values across the content to mainProcess boundaries. r=credential-management-reviewers,sgalich

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/24dd86b49420