1802132 - mach bootstrap for android fails on Fedora 37 - cannot install ncurses-compat-libs

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect, P3)

Description

[Jamie Nicol [:jnicol]]

I updated one of my computers to Fedora 37 this morning, and now mach bootstrap for android fails:

subprocess.CalledProcessError: Command '['sudo', 'dnf', 'install', 'ncurses-compat-libs']' returned non-zero exit status 1.

  File "/home/jamie/src/gecko/python/mozboot/mozboot/mach_commands.py", line 43, in bootstrap
    bootstrapper.bootstrap(command_context.settings)
  File "/home/jamie/src/gecko/python/mozboot/mozboot/bootstrap.py", line 350, in bootstrap
    getattr(self.instance, "install_%s_packages" % application)(mozconfig_builder)
  File "/home/jamie/src/gecko/python/mozboot/mozboot/centosfedora.py", line 84, in install_mobile_android_packages
    self.dnf_install(*self.mobile_android_packages)
  File "/home/jamie/src/gecko/python/mozboot/mozboot/base.py", line 475, in dnf_install
    self.run_as_root(command)
  File "/home/jamie/src/gecko/python/mozboot/mozboot/base.py", line 440, in run_as_root
    subprocess.check_call(command, stdin=sys.stdin)
  File "/usr/lib64/python3.11/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)

ncurses-compat-libs was removed from Fedora repos for 37: https://packages.fedoraproject.org/pkgs/ncurses/ncurses-compat-libs/index.html

Commenting out this line allows bootstrap to succeed, and I have successfully built geckoview without it. It was added in bug 1441579. Perhaps we can drop this requirement now we are using a more recent NDK?

Comment 1

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Sounds reasonable, but we should probably do it conditionally based on OS version so that people using older versions of Fedora don't have the opposite problem.

Comment 2

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1802132 - Only install `ncurses-compat-libs` on Fedora if OS version is less than 37 r?#build

ncurses-compat-libs was removed in Fedora 37, so we should only
install it on older versions.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1802132 - Remove all bootstrap code that installs packages specific for android builds on Linux.

Nowadays, none of these are necessary. Some were there for compatibility
reasons (old ncurses, 32-bits libraries) that are long gone, and in the
case of openSUSE, it was not updated when we made the generic android
code bootstrap a JDK itself in bug 1740358.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f708b55d5e2
Remove all bootstrap code that installs packages specific for android builds on Linux. r=firefox-build-system-reviewers,ahochheiden

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/8f708b55d5e2