Closed Bug 1802139 Opened 1 year ago Closed 1 year ago

No borders for the bookmarks folder drop-down

Categories

(Firefox :: Bookmarks & History, defect, P3)

Desktop
Windows 7
defect

Tracking

()

VERIFIED FIXED
109 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- unaffected
firefox108 --- verified
firefox109 --- verified

People

(Reporter: sbadau, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Found in

  • Firefox 108.0b5

Affected versions

  • Nightly 109.0a1
  • Firefox 108.0b5

Tested platforms

  • Affected platforms: Windows 7, Windows 8.1
  • Unaffected platforms: macOS 11.7, Ubuntu 20.04, Windows 10

Preconditions

  • set the Bookmarks Toolbar to Always Show.

Steps to reproduce

  1. On the Bookmarks Toolbar - create a New Folder.
  2. Click on the folder and observe the dropdown.

Expected result

  • The dropdown's borders should be properly displayed.

Actual result

  • The dropdown's borders are not visible at all on Beta 108 and are lacking the shadow on Nightly 109.0a1.

Regression range

Additional notes

  • Beta 108 is more affected than Nightly 109.0a1 where the landing of Bug 1796940 made the borders visible even if the shadow is still missing.
Depends on: 1796940

emilio, could you please take a look here?

Itiel, how do you feel about us uplifting bug 1796940 to beta in order to mitigate this issue?

Flags: needinfo?(itiel_yn8)
Flags: needinfo?(emilio)
OS: Windows → Windows 7

I attached a relatively targeted patch to the bug for beta, in case we don't feel very confident about uplifting bug 1796940.

My preferred fix for Nightly would be bug 1801845, wdyt?

Flags: needinfo?(emilio) → needinfo?(dao+bmo)

This can be tested in Win10+ too, as long as you add
browser.display.windows.non_native_menus=0.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
See Also: → 1801845
Attachment #9304972 - Attachment description: Bug 1802139 - Make box-shadows more generic across platforms r?dao,emilio → Bug 1802139 - Make panel/menupopup box-shadows more generic across platforms r?dao,emilio

(In reply to Dão Gottwald [::dao] from comment #1)

emilio, could you please take a look here?

Itiel, how do you feel about us uplifting bug 1796940 to beta in order to mitigate this issue?

Should be fine, but I'd feel more comfortable if QE will sanity check bug 1796940 first, unless 108 is right around the corner.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I attached a relatively targeted patch to the bug for beta, in case we don't feel very confident about uplifting bug 1796940.

My preferred fix for Nightly would be bug 1801845, wdyt?

As mentioned on matrix, that patch seems too risky to me, but even if we decide to go that route I'd prefer landing my patch first so we'd have a baseline to compare to if bug 1801845 will end up with regressions or will be needed to backout.
I haven't tested your patch for beta but it looks like it'd work, even if I don't really like the approach... Mine seems cleaner imo.

Flags: needinfo?(itiel_yn8)
Priority: -- → P3
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/6ae840d533df
Make panel/menupopup box-shadows more generic across platforms r=emilio
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Flags: needinfo?(dao+bmo)

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

I still think we should land attachment 9304928 [details] for beta, wdyt?

Flags: needinfo?(itiel_yn8)
Flags: needinfo?(emilio)
Flags: needinfo?(dao+bmo)

LGTM

Flags: needinfo?(itiel_yn8)

Comment on attachment 9304928 [details]
Bug 1802139 - Simple patch for beta. r=dao,itiel

Beta/Release Uplift Approval Request

  • User impact if declined: comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is the simplest/less-risky CSS patch that fixes the bug for beta.
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9304928 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9304928 [details]
Bug 1802139 - Simple patch for beta. r=dao,itiel

Approved for 108.0b9

Attachment #9304928 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as fixed on the latest Nightly 109.0a1 and on Firefox 108.b9 - tested on Windows 7 x64 and on Windows 8.1 x64.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+

This got uplifted, so removing now unneeded NI.

Flags: needinfo?(dao+bmo)
Blocks: 1701875
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: