Closed Bug 1802159 Opened 3 years ago Closed 3 years ago

`ipc/chromium/src/third_party` third-party C++ file pruning

Categories

(Core :: IPC, task)

Product:
Core
Component:
IPC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: chadrien, Assigned: chadrien)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Bug 1802159 - Remove `ipc/chromium/src/third_party` dead C++ cluster 1. r?sylvestre,marco
48 bytes, text/x-phabricator-request
Details | Review
Bug 1802159 - Remove `ipc/chromium/src/third_party` dead C++ cluster 2. r?sylvestre,marco
48 bytes, text/x-phabricator-request
Details | Review

This bug reports tracks the removal of unused C++ files in the ipc/chromium/src/third_party third-party library.

Files confirmed to be removable (by truncating sources, not interface):

Cluster 1:

Cluster 2:

Cluster 3:

Blocks: 1802160
Component: Third Party Packaging → IPC
Product: Firefox Build System → Core
No longer depends on: 1801850
No longer blocks: 1802160
No longer depends on: 1801087, 1801894, 1802158, 1801893
Assignee: nobody → adrien.champion
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e4833393b80 Remove `ipc/chromium/src/third_party` dead C++ cluster 1. r=jld https://hg.mozilla.org/integration/autoland/rev/3a5a51fb1df4 Remove `ipc/chromium/src/third_party` dead C++ cluster 3. r=jld https://hg.mozilla.org/integration/autoland/rev/cebac9d69d82 Remove `ipc/chromium/src/third_party` dead C++ cluster 2. r=jld

Backed out for causing build bustages

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: ld.lld: error: undefined hidden symbol: event_strlcpy_
    clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
    gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:540: libxul.so] Error 1
    gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/library/gtest/target] Error 2
    ld.lld: error: undefined hidden symbol: event_strlcpy_
Flags: needinfo?(adrien.champion)
Attachment #9305793 - Attachment is obsolete: true

(In reply to Cristian Tuns from comment #5)

Backed out for causing build bustages

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: ld.lld: error: undefined hidden symbol: event_strlcpy_
    clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
    gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:540: libxul.so] Error 1
    gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/library/gtest/target] Error 2
    ld.lld: error: undefined hidden symbol: event_strlcpy_

I removed this commit after discussing it with @decoder and @marco

Flags: needinfo?(adrien.champion)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f752b4f6e0fa Remove `ipc/chromium/src/third_party` dead C++ cluster 1. r=sylvestre,jld https://hg.mozilla.org/integration/autoland/rev/c462bd8d22da Remove `ipc/chromium/src/third_party` dead C++ cluster 2. r=jld

https://hg.mozilla.org/mozilla-central/rev/f752b4f6e0fa
https://hg.mozilla.org/mozilla-central/rev/c462bd8d22da

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: