1802217 - style of download dialog regressed

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[Sören Hentzschel]

Attachment: screenshot

Bug 1801339 regressed the style of the download dialog. Please see the attached screenshot.

STR:

1. Make sure you have Firefox configured to always ask for DMG files
2. Download a DMG file from https://archive.mozilla.org/pub/firefox/nightly/2022/11/2022-11-23-09-44-29-mozilla-central/
3. See the dialog.

Comment 1

[Sören Hentzschel]

Attachment: expected look

For comparison a screenshot of the expected look (Firefox 108 Beta)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1802217 - Fix bug 1801339 in a different way. r=mconley

Flexing the label doesn't quite work for start-aligned labels. This
should be more targeted.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d25693f4ece
Fix bug 1801339 in a different way. r=mconley

Comment 5

[Marian-Vasile Laza]

Backed out changeset 1d25693f4ece (Bug 1802217) for causing mochitest failures on test_bug562554.xhtml.
Backout link
Push with failures <--> c3
Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d871bfe687d
Fix bug 1801339 in a different way. r=mconley

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5d871bfe687d

Comment 9

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue with Firefox 109.0a1 (2022-11-23) on macOS 11.
The issue is verified fixed with Firefox 109.0b2 on Windows 10x64, macOS 11, and Ubuntu 20.04. The download dialogue is correctly displayed on the en-US and DE locales.