1802245 - The second screen of the new onboarding is scrollable on some devices

Status: RESOLVED FIXED

(Focus :: General, defect)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/focus-android/issues/7645.

Steps to reproduce

1. Install the latest Focus Nightly local build.
2. Tap on "Get started" button, in order to get to the second onboarding screen.
3. Observe the second screen.

Expected behavior

The second onboarding screen isn't scrollable.

Actual behavior

The second onboarding screen is scrollable.

Device information

• Android device: Sony Xperia Z5 Premium (Android 7.1.1 - 2160 x 3840 pixels, 16:9 ratio (~806 ppi density)), Google Pixel (Android 10 - 1080 x 1920 pixels (~441 ppi pixel density)), and HTC 10(Android 8 - 1440 x 2560 pixels (~565 ppi pixel density))
• Focus version: local build of Focus Nightly from 9/9
• Not reproducible on Samsung Galaxy Note 8 (Android 9), Oppo Reno 6 (Android 12)
• The short videos are below.

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1802245 - Remove redundant column and use custom background modifier.

Comment 3

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1802245 - Use background modifier in other composables.

Depends on D239997

Comment 4

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1802245 - Remove scrolling and ensure content fits the screen.

Depends on D239998

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/627910d80306
Remove redundant column and use custom background modifier. r=android-reviewers,giorga
https://hg.mozilla.org/integration/autoland/rev/79c84c0febb6
Use background modifier in other composables. r=android-reviewers,giorga
https://hg.mozilla.org/integration/autoland/rev/fb064c309a01
Remove scrolling and ensure content fits the screen. r=android-reviewers,giorga

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/627910d80306
https://hg.mozilla.org/mozilla-central/rev/79c84c0febb6
https://hg.mozilla.org/mozilla-central/rev/fb064c309a01

Comment 7

[Mihai Adrian Carare [:mcarare]]

For QA: Please check the onboarding is completely visible on portrait and landscape, even on small screen devices. Thank you!

Comment 8

[Mira Lobontiu (Android QA)]

Attachment: 1802245.png

Verified on the Focus Nightly 138.0a1 build from 3/10 with:

• Google Pixel (Android 10),
• HTC 10 (Android 8), and
• Sony Xperia Z5 Premium (Android 7.1.1).