Closed Bug 1802279 Opened 1 year ago Closed 1 year ago

Use preference to enable WritableFileStream for testing

Categories

(Core :: DOM: File, defect, P3)

defect

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- unaffected
firefox108 --- wontfix
firefox109 --- wontfix
firefox110 --- fixed

People

(Reporter: jjalkanen, Assigned: jjalkanen)

References

(Regressed 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

The first iteration of FileSystemWritableFileStream implemented the API on the main thread of the content process. Because the IO operations potentially cause main thread performance "jank" when the API is in use, FileSystemWritableFileStream and its tests were disabled outside the worker context.

In order to catch regressions, web compatibility issues with the new code and to get feedback in real use cases, the API has to be enabled again.

Set release status flags based on info from the regressing bug 1798459

Hey Jari, are you planning to uplift this to 108? If not please mark 108 as unaffected or disabled in the tracking flags. Thanks!

Flags: needinfo?(jjalkanen)
Flags: needinfo?(jjalkanen)

Set release status flags based on info from the regressing bug 1798459

Summary: Re-enable FileSystemWritableFileStream and its tests on main thread → Enable FileSystemWritableFileStream for testing with preference
Summary: Enable FileSystemWritableFileStream for testing with preference → Enable FileSystemWritableFileStream with preference for testing
Attachment #9305065 - Attachment description: Bug 1802279 - Re-enable writable stream and its tests on main thread. r=#dom-storage → Bug 1802279 - Use preference to enable WritableFileStream for testing. r=#dom-storage
Keywords: leave-open
Blocks: 1807198

Comment on attachment 9309662 [details]
Bug 1802279 - Extend preference to disable WritableFileStream in all contexts. r=#dom-storage

Revision D165447 was moved to bug 1807198. Setting attachment 9309662 [details] to obsolete.

Attachment #9309662 - Attachment is obsolete: true
Keywords: leave-open
Attachment #9309662 - Attachment is obsolete: false
Pushed by jjalkanen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0dfdef11b0f
Use preference to enable WritableFileStream for testing. r=dom-storage-reviewers,jesup,janv
https://hg.mozilla.org/integration/autoland/rev/f66aa3303672
Extend preference to disable WritableFileStream in all contexts. r=dom-storage-reviewers,janv

xpcshell tests need to have this flag enabled now.

Backed out for causing causing multiple failures in dom/fs/test.

Also this failure and another is this.

Flags: needinfo?(jjalkanen)

And crashtests

Flags: needinfo?(jjalkanen)
Pushed by jjalkanen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/877341b559ec
Use preference to enable WritableFileStream for testing. r=dom-storage-reviewers,jesup,janv
https://hg.mozilla.org/integration/autoland/rev/d6aa92d26559
Extend preference to disable WritableFileStream in all contexts. r=dom-storage-reviewers,janv
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Regressions: 1807395
Regressions: 1807484
Summary: Enable FileSystemWritableFileStream with preference for testing → Use preference to enable WritableFileStream for testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: