Use preference to enable WritableFileStream for testing
Categories
(Core :: DOM: File, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox107 | --- | unaffected |
firefox108 | --- | wontfix |
firefox109 | --- | wontfix |
firefox110 | --- | fixed |
People
(Reporter: jjalkanen, Assigned: jjalkanen)
References
(Regressed 2 open bugs, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
The first iteration of FileSystemWritableFileStream implemented the API on the main thread of the content process. Because the IO operations potentially cause main thread performance "jank" when the API is in use, FileSystemWritableFileStream and its tests were disabled outside the worker context.
In order to catch regressions, web compatibility issues with the new code and to get feedback in real use cases, the API has to be enabled again.
Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Comment 2•1 year ago
|
||
Set release status flags based on info from the regressing bug 1798459
Comment 3•1 year ago
|
||
Hey Jari, are you planning to uplift this to 108? If not please mark 108 as unaffected or disabled in the tracking flags. Thanks!
Updated•1 year ago
|
Updated•1 year ago
|
Comment 4•1 year ago
|
||
Set release status flags based on info from the regressing bug 1798459
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 5•1 year ago
|
||
Depends on D162319
Comment 6•1 year ago
|
||
Comment on attachment 9309662 [details]
Bug 1802279 - Extend preference to disable WritableFileStream in all contexts. r=#dom-storage
Revision D165447 was moved to bug 1807198. Setting attachment 9309662 [details] to obsolete.
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c0dfdef11b0f Use preference to enable WritableFileStream for testing. r=dom-storage-reviewers,jesup,janv https://hg.mozilla.org/integration/autoland/rev/f66aa3303672 Extend preference to disable WritableFileStream in all contexts. r=dom-storage-reviewers,janv
Assignee | ||
Comment 8•1 year ago
|
||
xpcshell tests need to have this flag enabled now.
Comment 9•1 year ago
|
||
Backed out for causing causing multiple failures in dom/fs/test.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | dom/fs/test/xpcshell/test_writableFileStream_worker.js | xpcshell return code: 0
Comment 10•1 year ago
|
||
Yeah, but mochitests need that too, just add the additional pref to these arrays:
https://searchfox.org/mozilla-central/rev/b0844a16d60042c8e1e8f50465a89c1696d283fb/dom/fs/test/mochitest/head.js#66
https://searchfox.org/mozilla-central/rev/b0844a16d60042c8e1e8f50465a89c1696d283fb/dom/fs/test/xpcshell/head.js#64
Comment 12•1 year ago
|
||
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/877341b559ec Use preference to enable WritableFileStream for testing. r=dom-storage-reviewers,jesup,janv https://hg.mozilla.org/integration/autoland/rev/d6aa92d26559 Extend preference to disable WritableFileStream in all contexts. r=dom-storage-reviewers,janv
Comment 13•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/877341b559ec
https://hg.mozilla.org/mozilla-central/rev/d6aa92d26559
Updated•1 year ago
|
Updated•1 year ago
|
Description
•