1802619 - Crash in [@ java.lang.NullPointerException: at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:20)]

Status: VERIFIED FIXED

(Fenix :: History, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/119847c2-5663-432e-90e5-004ec0221118

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:20)
	at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:38)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:226)
	at android.os.Looper.loop(Looper.java:313)
	at android.app.ActivityThread.main(ActivityThread.java:8663)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:567)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)

Comment 1

[Chris Peterson [:cpeterson]]

This crash looks like a regression in 107.0a1 on or before 2022-10-02.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on beta

For more information, please visit auto_nag documentation.

Comment 3

[Vlad Dreghici [:vdreghici]]

Attachment: delete_browsing_data_crash.mp4

Video reproducing the crash

Comment 4

[Vlad Dreghici [:vdreghici]]

The steps for reproducing the crash are the following:

• Go to settings.
• Go to delete browsing data.
• Select any options BUT include the "Open tabs" option, since it is the only one taking the user to the settings page after deletions is done.
• Tap Delete browsing data.
• Tap Delete.
• While the process of deletion is in progress, the user is still able to tap "Delete browsing data again", leading to displaying the confirmation dialog again.
• If the process is finished and user is taken back, if the confirmation dialog is still displayed and Delete button is pressed after user was taken back to settings, the app will crash.
  (Check video attached)

Expected behavior:

• When the deletion is in progress, the user should not be able to tap again the "Delete browsing data" and open the dialog.

Comment 5

[BMO Automation]

Attachment: [mozilla-mobile/fenix] Bug 1802619: Disable delete browsing button when deletion in progress (#28672)

Comment 6

[Lorand Janos]

Verified as fixed on the latest Nightly 111.0a1 (2023-01-31) build.
Devices used:

• Xiaomi Mi11 Lite (Android 11).
• Oppo Find X5 (Android 12).
• Google Pixel 7 (Android 13).

Marking the ticket as verified.

Comment 7

[Pascal Chevrel:pascalc]

Do we want to uplift that patch in our last beta or is it OK to let it ride the 111 train and potentially uplift the patch for the 110 planned dot release?

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Pascal Chevrel:pascalc from comment #7)

Do we want to uplift that patch in our last beta or is it OK to let it ride the 111 train and potentially uplift the patch for the 110 planned dot release?

I think we should uplift the fix to beta. The fix looks pretty safe. It only affects code paths related to the settings for deleting browsing history, so even if the fix introduces a new bug, the impact would be small.

Comment 9

[BMO Automation]

Attachment: [mozilla-mobile/fenix] Bug 1802619: Disable delete browsing button when deletion in progress (backport #28672) (#28729)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Merged to v110:
https://github.com/mozilla-mobile/fenix/commit/76b9f93d614f4e7245dbbc867c3fc2281ebe5b6f

Comment 11

[Lorand Janos]

Verified as fixed on the latest Beta 110.0b6 build using the steps above.
The "Delete browsing data" button cannot be tapped while the process of deletion is in progress.
Device used: Google Pixel 7 (Android 13).
Marking as verified for 110.