1802706 - Confirmation window to delete cookies and website data is shown incorrectly

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Karsten Thomann]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0

Steps to reproduce:

I have a german Nightly version, the English translation may be different.
Go to preferences, Data and Security (the menu with the lock symbol), Cookies and Website data area, and click manage data.
Issue 1 (clipboard2 image):
Delete the data of at least 50+ sites and click save changes.
The Button to delete them permanently is outside the visible screen area as it should be a list where I can scroll down, the window size is for the full length of the list.
Issue 2 (clipboard3 image):
delete for example the data from three sites and without really checking you see only 2, even as there is more than enough free space in the window to show all.

Actual results:

Issue 1:
It should show a list that can be scrolled down instead of a window that is too long.
Issue 2:
It should show all websites and not hide a site.

Expected results:

see actual results

Comment 1

[Karsten Thomann]

Attachment: Clipboard02.jpg

Comment 2

[Karsten Thomann]

Attachment: Clipboard03.jpg

Comment 3

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking: Cookies' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

21:38.13 INFO: Narrowed integration regression window from [bf1bc477, a913c869] (3 builds) to [bf1bc477, 1e4afe94] (2 builds) (~1 steps left)
21:38.13 INFO: No more integration revisions, bisection finished.
21:38.13 INFO: Last good revision: bf1bc477f95d9ca0686bf22e577727d11be616fc
21:38.13 INFO: First bad revision: 1e4afe94c89bf0d123accce7f6fe4565be09d5c0
21:38.13 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bf1bc477f95d9ca0686bf22e577727d11be616fc&tochange=1e4afe94c89bf0d123accce7f6fe4565be09d5c0

Hey emilio, looks like there's some fallout from bug 1796915 related to the cookie removal confirmation dialog. Got a second to look at it?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Of course!

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1802706 - Convert site data settings confirmation dialog to modern flex layout. r=mconley,Gijs,dao

TIL we had preferences dialogs that weren't subdialogs!

contain: size obviously doesn't work on those, and since they're not
subdialogs they don't have the "make them scroll if too tall" code,
causing this.

Converting this one is trivial tho, so do that.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08c1cafc9cf0
Convert site data settings confirmation dialog to modern flex layout. r=mconley,settings-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/08c1cafc9cf0

Comment 9

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9305648 [details]
Bug 1802706 - Convert site data settings confirmation dialog to modern flex layout. r=mconley,Gijs,dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very-scoped CSS fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9305648 [details]
Bug 1802706 - Convert site data settings confirmation dialog to modern flex layout. r=mconley,Gijs,dao

Approved for 108.0b9

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1cb9f6ad88f9

Comment 13

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

I have reproduced this issue on Win 7 x64, using STR from comment 0, on an affected Nightly build (2022-11-26).

The issue is verified as fixed on the latest builds, Beta 108 and Nightly 109, under Win 10 x64 and Win 7 x64.