1802832 - Check orientation permission before throwing NotSupportedError

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Makoto Kato [:m_kato]]

https://w3c.github.io/screen-orientation/#lock-method

3. If document has the sandboxed orientation lock browsing context flag set, or doesn't meet the pre-lock conditions, or locking would be a security risk, return a promise rejected with a "SecurityError" DOMException and abort these steps.
4. If the user agent does not support locking the screen orientation to orientation, return a promise rejected with a "NotSupportedError" DOMException and abort these steps.

Previous spec was different order.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Makoto-san, do you know who maintains around it? If so, could you redirect this ni? to the person to consider the priority and severity.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1802832 - Check orientation permission before throwing NotSupportedError. r=smaug

Before updating spec, the order was

1. Throw NotSupportedError if user agent doesn't support lock()
2. Check orientation lock permission.

But After updated (https://w3c.github.io/screen-orientation/#lock-method),
the order is

1. Check orientation lock permission.
2. Throw NotSupportedError if user agent doesn't support lock()

So we should check orientation permission / pre-lock conditions before
throwing NotSupportedError.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/223177f5d721