180291 - OpenVMS build -> GNV: LDAP Changes

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect)

Description

[Colin Blake]

This bug report will track the LDAP changes with the "move OpenVMS build to GNV"
work (meta-bug 180288).

Comment 1

[Colin Blake]

Attachment: LDAP changes

Comment 2

[Colin Blake]

Mark, could you start the review process please, and tell me how many levels of
review I need for LDAP modules. Thanks.

Comment 3

[Mark Smith [:mcs]]

Yes, I will review these changes soon. At a glance I don't see anything risky
(not likely to break other platforms) with the possible exception of the
libldap/open.c change (I will have to look at that more closely).

As for the review process, the Mozilla client builds currently do not pick up
the LDAP code from the trunk; they pull from ldapcsdk_50_client_branch. If you
just want these changes on the trunk, I can review them. If you want them on the
LDAP branch that is used by the Mozilla client then we need a module owner
approval (from me), one review (which I will do), a superreview, and approval to
commit.

Comment 4

[Colin Blake]

The open.c changes is inside an existing #ifdef VMS, so its not going to break
anyone else.

The changes need to go into ldapcsdk_50_client_branch, so that Mozilla picks
them up.

Once you're reviewed can you tell me who I should go to for superview and
checkin approval.

Many thanks.

Comment 5

[Colin Blake]

I REALLY need to get these changes in for OpenVMS, and I'd like to do so before
Thanksgiving. Its been 11 days since I posted the patch. If you can't review the
patch at this time, can you suggest someone else who can? I need to move
forward. Thanks, Colin.

Comment 6

[Mark Smith [:mcs]]

Comment on attachment 106353 [details] [diff] [review]
LDAP changes

Sorry for the delay. r=mcs.

Comment 7

[Colin Blake]

Thanks Mark. Should I just request the super-review from any of the usual gang,
or is there a preferred super-reviewer for ldap?

Comment 8

[Mark Smith [:mcs]]

No preferred SR'r... I just posted a request to the newsgroup.

Comment 9

[Colin Blake]

Comment on attachment 106353 [details] [diff] [review]
LDAP changes

Looking for a superreviewer

Comment 10

[Colin Blake]

This is blocking my work on Mozilla 1.3. Setting severity and milestone fields
according.

Comment 11

[Asa Dotzler [:asa]]

making a non-specific super-review request probably isn't gonna do much good.
you're much more likely to get a response if you make the request of a specific
super-reviewer.

Comment 12

[Colin Blake]

Comment on attachment 106353 [details] [diff] [review]
LDAP changes

Brendan, could you sr this please.

Comment 13

[Brendan Eich [:brendan]]

Comment on attachment 106353 [details] [diff] [review]
LDAP changes

rs=[e-mail], cc'd seawood in case he has anything to add.

/be

Comment 14

[hacker formerly known as [e-mail]]

wfm

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 106353 [details] [diff] [review]
LDAP changes

a=asa for checkin to 1.3a

Comment 16

[Colin Blake]

Checked in to trunk.

Comment 17

[Frankie]

Spam for bug 129472