This bug report will track the LDAP changes with the "move OpenVMS build to GNV" work (meta-bug 180288).
Mark, could you start the review process please, and tell me how many levels of review I need for LDAP modules. Thanks.
Yes, I will review these changes soon. At a glance I don't see anything risky (not likely to break other platforms) with the possible exception of the libldap/open.c change (I will have to look at that more closely). As for the review process, the Mozilla client builds currently do not pick up the LDAP code from the trunk; they pull from ldapcsdk_50_client_branch. If you just want these changes on the trunk, I can review them. If you want them on the LDAP branch that is used by the Mozilla client then we need a module owner approval (from me), one review (which I will do), a superreview, and approval to commit.
The open.c changes is inside an existing #ifdef VMS, so its not going to break anyone else. The changes need to go into ldapcsdk_50_client_branch, so that Mozilla picks them up. Once you're reviewed can you tell me who I should go to for superview and checkin approval. Many thanks.
I REALLY need to get these changes in for OpenVMS, and I'd like to do so before Thanksgiving. Its been 11 days since I posted the patch. If you can't review the patch at this time, can you suggest someone else who can? I need to move forward. Thanks, Colin.
Comment on attachment 106353 [details] [diff] [review] LDAP changes Sorry for the delay. r=mcs.
Thanks Mark. Should I just request the super-review from any of the usual gang, or is there a preferred super-reviewer for ldap?
No preferred SR'r... I just posted a request to the newsgroup.
Status: NEW → ASSIGNED
Comment on attachment 106353 [details] [diff] [review] LDAP changes Looking for a superreviewer
This is blocking my work on Mozilla 1.3. Setting severity and milestone fields according.
Severity: normal → blocker
Target Milestone: --- → mozilla1.3
making a non-specific super-review request probably isn't gonna do much good. you're much more likely to get a response if you make the request of a specific super-reviewer.
Comment on attachment 106353 [details] [diff] [review] LDAP changes Brendan, could you sr this please.
Attachment #106353 - Flags: superreview? → superreview?(brendan)
Comment on attachment 106353 [details] [diff] [review] LDAP changes email@example.com, cc'd seawood in case he has anything to add. /be
Attachment #106353 - Flags: superreview?(brendan) → superreview+
Comment on attachment 106353 [details] [diff] [review] LDAP changes a=asa for checkin to 1.3a
Attachment #106353 - Flags: approval1.3a? → approval1.3a+
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Spam for bug 129472
QA Contact: nobody → nobody
You need to log in before you can comment on or make changes to this bug.