1802945 - Labels in chat UI don't overflow with ellipsis

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

We use a lot of labels and descriptions in the chat UI, for the conversation name in the conversation list and conv info, the topic, the participant names in the participants list, titles in the sidebar etc. It appears these labels no longer overflow with an ellipsis on trunk. In the 108 beta it's still fine.

This might be some change with how ellipsis works for the labels, so we'll have to update our styles to properly add ellipsis overflows in those places.

Regression range (haven't translated this to m-c yet):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=c1b5a7c88c0852e59815d98f54ab8d00c9b40a60&tochange=618f8ad3da6fa3f74d2ad3d4fb3e7fe4d08a859d

Comment 1

[Martin Giger [:freaktechnik]]

m-c range is https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=efbd04cb07486419679cf588ba6095f7ef9edef6&tochange=1c45b47c2aa0f76cedd400fa82e0e88a6cb68faa and as such, I'd think bug 1799460 is the likely culprit.

Comment 2

[Martin Giger [:freaktechnik]]

Removing these lines: https://searchfox.org/mozilla-central/rev/77a39e7595198fd30b57550749c15761d30314fb/toolkit/content/xul.css#142-150 fixes the ellipsis not appearing.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Can you point me to the c-c code? How are you creating the relevant labels / description? At a glance setting display: inline-/block on them should fix it.

Comment 4

[Martin Giger [:freaktechnik]]

One example would be https://searchfox.org/comm-central/rev/d99c2ec689b941ae120776f423726f59875957a5/mail/components/im/content/chat-conversation-info.js#45 (see also its wonderful inheritedAttribute). The only rules we define are https://searchfox.org/comm-central/rev/d99c2ec689b941ae120776f423726f59875957a5/mail/themes/shared/mail/chat.css#456-458

Overriding the display property would probably fix it given the existing xul.css display property doesn't behave correctly with the ::before overflow.

Comment 5

[Martin Giger [:freaktechnik]]

It also seems that labels that didn't used to need the crop attribute now do?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Are you using -moz-box-layout: legacy? That I'm not sure would behave properly... Re. cropping of labels, if we were cropping without the crop attribute then I don't know how that worked :)

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1802945 - Fix ellipsis in chat UI. r=#thunderbird-front-end-reviewers

The encryption label never properly had an ellipsis overflow, now does.

Depends on D163246

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a9d1cb56e6bc
Fix ellipsis in chat UI. r=aleca