1803036 - Some TokenStream errors have poor location information

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Ted Campbell [:tcampbell]]

Parsing things like 1__X will throw a syntax error for the repeated underscores, but the location error will be on the X rather than the underscore.

This is due to a few places in TokenStream not calling ungetCodeUnit in error paths when using getCodeUnit instead of peekCodeUnit.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1803036 - Improve error locations for JS numeric separators. r?mgaudet

When reporting errors for invalid numeric separators, we should try to point at
the separator character rather than what follows. This patch adds a few calls to
ungetCodeUnit, similar to other error paths in the TokenStream code.

Comment 2

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5dcbc983096b