Open Bug 1803104 Opened 2 years ago Updated 2 years ago

assertion for permissionKey in PermissionManager::SetPermissionsWithKey() is tripping over default ports

Categories

(Core :: Permission Manager, enhancement)

enhancement

Tracking

()

People

(Reporter: freddy, Unassigned)

Details

This showed up as a related symptom when debugging another bug (bug 1793597).

If you set permissions for a website visited with an explicit port (e.g., aPermissionKey = http://example.com:80) then parsing round-trips through NS_NewURI within GetPrincipalFromOrigin() loses the port (permissionKey = http://kb.mozillazine.org, no port).

This trips the [assertion which requires them to be exactly equal](https://searchfox.org/mozilla-central/rev/670e2e0999f04dc7734c8c12b2c3d420a1e31f12/extensions/permissions/PermissionManager.cpp#3248] leading to an assertion failure.

I'm not sure how important that assertion is and if you want to relax the comparison check, but I figured we'd better not leave this unfiled.

You need to log in before you can comment on or make changes to this bug.