Did the "new-metric-capture-emulation" ping make it to release?
Categories
(Toolkit :: Telemetry, task, P1)
Tracking
()
People
(Reporter: chutten, Assigned: perry.mcmanis)
References
Details
We've been seeing a lot of nodc pings in the FOG Monitoring Dashboard and I've been ignoring them. But maybe I should've been paying more attention, because it looks as though the pings are coming in from release:
https://sql.telemetry.mozilla.org/queries/88939/source#220288
What's the deal with that? We thought we were really careful to only leave it in Nightly for only 10 days.
|
Assignee | |
Comment 1•3 years ago
|
||
Unfortunately, the answer to this appears to be yes:
https://searchfox.org/mozilla-release/source/toolkit/components/glean/src/init/user_activity.rs#38
The code that put it in the application was targeted at 107:
https://hg.mozilla.org/mozilla-central/rev/c4f2f3f71ae6
However, the stack that pulled the code out was targeted at 108:
https://hg.mozilla.org/integration/autoland/rev/d23fe3a7e53cefcc7008d711e755b34c075c7002
At this point:
- we will likely see some long tail of new metric capture pings/nodc pings from release clients for a very long time
- no patches are necessary at this point; 108 will disable this
Learning:
- in the future, it may be preferable to work with a release manager to actually revert code, than to write new code that removes it. Even though it seemed like we would not have any issues with code freeze, the target version for the "reversion" end up biting us here.
|
|
Assignee | |
Comment 2•3 years ago
|
||
We will not be making any additional code changes as changes are already landed, so closing this.
Description
•