some files have too many #includes (not relevant to file)

ASSIGNED
Assigned to

Status

()

Core
Editor
ASSIGNED
15 years ago
11 years ago

People

(Reporter: Kathleen Brade, Assigned: Kathleen Brade)

Tracking

Trunk
mozilla1.3beta
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

15 years ago
nsHTMLEditorStyle.cpp has lots of #includes of which many are not needed.  Other
files may have similar problems?
(Assignee)

Comment 1

15 years ago
Created attachment 107932 [details] [diff] [review]
remove some headers
(Assignee)

Updated

15 years ago
Attachment #107932 - Flags: superreview?(kin)
Attachment #107932 - Flags: review?(jfrancis)

Comment 2

15 years ago
Comment on attachment 107932 [details] [diff] [review]
remove some headers

sr=kin@netscape.com
Attachment #107932 - Flags: superreview?(kin) → superreview+

Updated

15 years ago
Attachment #107932 - Flags: review?(jfrancis) → review+
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.3beta
(Assignee)

Comment 3

15 years ago
Created attachment 127314 [details] [diff] [review]
include cleanup for composer/src
Attachment #107932 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #127314 - Flags: superreview?(kin)
Attachment #127314 - Flags: review?(kaie)

Comment 4

15 years ago
Comment on attachment 127314 [details] [diff] [review]
include cleanup for composer/src

r=kaie
assuming you have tested it still compiles :-)
Attachment #127314 - Flags: review?(kaie) → review+

Comment 5

15 years ago
Comment on attachment 127314 [details] [diff] [review]
include cleanup for composer/src

sr=darin
Attachment #127314 - Flags: superreview?(kin) → superreview+
(Assignee)

Comment 6

15 years ago
Created attachment 128006 [details] [diff] [review]
fix some includes in editor/idl

obsoleting patch that already landed
Attachment #127314 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #128006 - Flags: superreview?(tor)
Attachment #128006 - Flags: review?(kaie)

Comment 7

15 years ago
Comment on attachment 128006 [details] [diff] [review]
fix some includes in editor/idl

r=kaie
Attachment #128006 - Flags: review?(kaie) → review+

Updated

15 years ago
Attachment #128006 - Flags: superreview?(tor) → superreview+
QA Contact: sujay → editor
You need to log in before you can comment on or make changes to this bug.