1803370 - [DNR] Consider changes on the enforced rule limits

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to Bug 1745763 we want to consider further changes to the rule limits enforced by DNR, e.g.:

• consider bumps to the max ruleset and max enabled rulesets limits (related to https://github.com/w3c/webextensions/issues/318)
• consider bumps to the max number of dynamic rules (related to https://github.com/w3c/webextensions/issues/319)
• allowing extensions to exceed the guaranteed minimum static rules count (which in chrome is allowed up until a global maximum number of static rules count is reached, we want to consider doing the same but also other alternative approaches, as long as the extension will still be able to use getAvailableRulesCount to figure out how much more enabled rules are allowed to the particular extension)

Comment 1

[Rob Wu [:robwu]]

We discussed rule limits in the WECG today. Chrome needs to follow up internally, but Safari and we did not object to raising limits:

• static rules to 100 (was 50)
• enabled static rules to 20 (was 10).
• dynamic rule limit to 30k (was 5k).

Additionally, I also asked about separating the quotas of session and dynamic rules. Safari is in favor, and Google needs internal follow-up again. See https://github.com/w3c/webextensions/issues/319#issuecomment-1343159403

Comment 2

[William Durand [:willdurand]]

I am going to submit 3 patches: one that updates MAX_NUMBER_OF_ENABLED_STATIC_RULESETS (from 10 to 20), one that updates MAX_NUMBER_OF_STATIC_RULESETS (from 50 to 100), and another one to use prefs to control the default values of the different limits.

Comment 3

[William Durand [:willdurand]]

Attachment: Bug 1803370 - Bump MAX_NUMBER_OF_ENABLED_STATIC_RULESETS from 10 to 20. r?rpl!

Comment 4

[William Durand [:willdurand]]

Attachment: Bug 1803370 - Introduce prefs for the different DNR limits. r?rpl!

Depends on https://phabricator.services.mozilla.com/D207529

Comment 5

[William Durand [:willdurand]]

Attachment: Bug 1803370 - Bump MAX_NUMBER_OF_STATIC_RULESETS from 50 to 100. r?rpl!

Depends on D207538

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cbd95c3104a
Bump MAX_NUMBER_OF_ENABLED_STATIC_RULESETS from 10 to 20. r=rpl
https://hg.mozilla.org/integration/autoland/rev/29ec216dea7d
Introduce prefs for the different DNR limits. r=rpl
https://hg.mozilla.org/integration/autoland/rev/f8c1297bb66e
Bump MAX_NUMBER_OF_STATIC_RULESETS from 50 to 100. r=rpl

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4cbd95c3104a
https://hg.mozilla.org/mozilla-central/rev/29ec216dea7d
https://hg.mozilla.org/mozilla-central/rev/f8c1297bb66e

Comment 8

[Rob Wu [:robwu]]

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #0)

As a followup to Bug 1745763 we want to consider further changes to the rule limits enforced by DNR, e.g.:

• consider bumps to the max ruleset and max enabled rulesets limits (related to https://github.com/w3c/webextensions/issues/318)

done in this bug.

• consider bumps to the max number of dynamic rules (related to https://github.com/w3c/webextensions/issues/319)

deferred to bug 1894119.

• allowing extensions to exceed the guaranteed minimum static rules count (which in chrome is allowed up until a global maximum number of static rules count is reached, we want to consider doing the same but also other alternative approaches, as long as the extension will still be able to use getAvailableRulesCount to figure out how much more enabled rules are allowed to the particular extension)

deferred to bug 1894115