Closed Bug 1803370 Opened 2 years ago Closed 1 month ago

[DNR] Consider changes on the enforced rule limits

Categories

(WebExtensions :: Request Handling, enhancement, P3)

enhancement

Tracking

(firefox127 fixed)

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: rpl, Assigned: willdurand)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira][wecg])

Attachments

(3 files)

As a followup to Bug 1745763 we want to consider further changes to the rule limits enforced by DNR, e.g.:

  • consider bumps to the max ruleset and max enabled rulesets limits (related to https://github.com/w3c/webextensions/issues/318)
  • consider bumps to the max number of dynamic rules (related to https://github.com/w3c/webextensions/issues/319)
  • allowing extensions to exceed the guaranteed minimum static rules count (which in chrome is allowed up until a global maximum number of static rules count is reached, we want to consider doing the same but also other alternative approaches, as long as the extension will still be able to use getAvailableRulesCount to figure out how much more enabled rules are allowed to the particular extension)
Whiteboard: [addons-jira] → [addons-jira][wecg]
See Also: → 1745764

We discussed rule limits in the WECG today. Chrome needs to follow up internally, but Safari and we did not object to raising limits:

  • static rules to 100 (was 50)
  • enabled static rules to 20 (was 10).
  • dynamic rule limit to 30k (was 5k).

Additionally, I also asked about separating the quotas of session and dynamic rules. Safari is in favor, and Google needs internal follow-up again. See https://github.com/w3c/webextensions/issues/319#issuecomment-1343159403

Severity: -- → N/A
Priority: -- → P2
See Also: → 1809721
See Also: → 1821033
Priority: P2 → P3

I am going to submit 3 patches: one that updates MAX_NUMBER_OF_ENABLED_STATIC_RULESETS (from 10 to 20), one that updates MAX_NUMBER_OF_STATIC_RULESETS (from 50 to 100), and another one to use prefs to control the default values of the different limits.

Assignee: nobody → wdurand
Keywords: leave-open
Keywords: leave-open
Pushed by wdurand@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4cbd95c3104a
Bump MAX_NUMBER_OF_ENABLED_STATIC_RULESETS from 10 to 20. r=rpl
https://hg.mozilla.org/integration/autoland/rev/29ec216dea7d
Introduce prefs for the different DNR limits. r=rpl
https://hg.mozilla.org/integration/autoland/rev/f8c1297bb66e
Bump MAX_NUMBER_OF_STATIC_RULESETS from 50 to 100. r=rpl
Regressions: 1891835
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
See Also: → 1894119

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #0)

As a followup to Bug 1745763 we want to consider further changes to the rule limits enforced by DNR, e.g.:

done in this bug.

deferred to bug 1894119.

  • allowing extensions to exceed the guaranteed minimum static rules count (which in chrome is allowed up until a global maximum number of static rules count is reached, we want to consider doing the same but also other alternative approaches, as long as the extension will still be able to use getAvailableRulesCount to figure out how much more enabled rules are allowed to the particular extension)

deferred to bug 1894115

See Also: → 1894115
See Also: → 1894128
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: