1803371 - Replace BodyStreamUnderlyingSourceAlgorithms::ErrorCallback with a destructor

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P2)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Per the spec the proper way to release resources is through clearing algorithms, which corresponds to the destructor of BodyStreamUnderlyingSourceAlgorithms in our case.

ErrorCallback was a way to coexist with the old JS Streams implementation, and given that we removed the JS one, we should now be able to follow the spec.

(CC'ing people who may be interested in the Streams implementation given their recent relevant works)

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1803371 - Part 4: Add UnderlyingSourceAlgorithmsBase::ReleaseObjects r=smaug

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1803371 - Part 1: Remove redundant ReadableStream::mAlgorithms r=smaug

ErrorCallback has surprisingly been broken as nothing currently set the algorithm with SetErrorAlgorithm. This patch removes the unused part, preparing another way in a child patch.

Comment 3

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1803371 - Part 2: Move Readable{ByteStream,StreamDefault}Controller::mAlgorithms to ReadableStreamController r=smaug

Depends on D163691

Comment 4

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1803371 - Part 3: Add UnderlyingSinkAlgorithmBase::ReleaseObjects r=smaug

This is not used yet but is needed for OPFS file unlock.

Depends on D163692

Comment 5

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1803371 - Part 5: Fix static analysis warnings r=smaug

Depends on D163528

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6999fbeaf9b
Part 1: Remove redundant ReadableStream::mAlgorithms r=smaug
https://hg.mozilla.org/integration/autoland/rev/8c94362f4f66
Part 2: Move Readable{ByteStream,StreamDefault}Controller::mAlgorithms to ReadableStreamController r=smaug
https://hg.mozilla.org/integration/autoland/rev/ae3687095860
Part 3: Add UnderlyingSinkAlgorithmBase::ReleaseObjects r=smaug
https://hg.mozilla.org/integration/autoland/rev/c36dd00b6a39
Part 4: Add UnderlyingSourceAlgorithmsBase::ReleaseObjects r=smaug
https://hg.mozilla.org/integration/autoland/rev/6e823d91d73d
Part 5: Fix static analysis warnings r=smaug

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b6999fbeaf9b
https://hg.mozilla.org/mozilla-central/rev/8c94362f4f66
https://hg.mozilla.org/mozilla-central/rev/ae3687095860
https://hg.mozilla.org/mozilla-central/rev/c36dd00b6a39
https://hg.mozilla.org/mozilla-central/rev/6e823d91d73d