Closed Bug 180364 Opened 21 years ago Closed 20 years ago
Oversized Uninstall theme button (long 3rd party name)
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.1) Gecko/20020826 Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.1) Gecko/20020826 When the name of a selected theme is too long, the uninstall them button grows beyond the edge of the window. Maybe just an "Uninstall" caption will be enough. Reproducible: Always Steps to Reproduce: 1. Download and installa a long name theme like Internet Explorer theme 2. Try to uninstall it through the Preferences window. 3. Actual Results: An ugly oversized uninstall button appears Expected Results: Don;t be so user firendly and just say "Uninstall" or incease height and justify.
Confirming with build 2003020511, Windows 2000.
Status: UNCONFIRMED → NEW
Ever confirmed: true
perhaps this is specific to [3rd party] themes with long names?
Summary: Oversized Uninstall theme button → Oversized Uninstall theme button (long 3rd party name)
Also if the theme name is too long then the scroll bar in the list of themes gets pushed to the right and eventually off the screen (providing you have enough themes installed to need the scrollbar).
I just discovered that it is not only a long theme name causing this, but also a long author name, especially if both are long. It seems that the uninstall button grows to the left as the name is getting longer and if the author name is also long then they will meet up and the author name will push the button to the left. The scrollbar for the list of themes and also the preview image seem to move with it. The author name should rather wrap onto the next line if it is too long and the skin name should not be included on the uninstall button.
I meant "...push the button to the right..." not left.
I don't think this (and some others) ought to block Bug 133627, which is terrible. But, since it does, imho, it should block everything it is broken on.
too late for 1.6. let's try for 1.7.
Flags: blocking1.6? → blocking1.6-
dveditz, could you help on this one?
Mass reassign of my non-Firefox bugs to email@example.com
Assignee: bugs → ben_seamonkey
cbiesinger, neil, any cycles to help out with some UI tweaking on this one?
let's just keep the button label as "Uninstall Theme", the name is shown to the left of it anyway
Assignee: ben_seamonkey → cbiesinger
Status: NEW → ASSIGNED
Attachment #144036 - Flags: review?(neil.parkwaycc.co.uk)
I had a look into trying to get the text to fit... unfortunately due to some reflow issues I was unable to get the text to wrap correctly, so that left two other options, cropping the text (using flex="1" crop="right" on the author) or changing the label into a plain readonly textfield as demonstrated here.
Comment on attachment 144036 [details] [diff] [review] patch Heh, the patch is so good you get to remove the code twice ;-)
Attachment #144036 - Flags: review?(neil.parkwaycc.co.uk) → review+
(In reply to comment #13) > Created an attachment (id=144037) > Not much of an alternative um, this patch fixes the "Author" field, not the button, which is what this bug is all about?
Attachment #144036 - Flags: superreview?(roc)
Attachment #144036 - Flags: superreview?(roc) → superreview+
Attachment #144036 - Flags: approval1.7?
Comment on attachment 144036 [details] [diff] [review] patch a=chofmann for 1.7
Attachment #144036 - Flags: approval1.7? → approval1.7+
Checking in content/pref-themes.js; /cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-themes.js,v <-- pref-themes.js new revision: 1.39; previous revision: 1.38 done Checking in locale/en-US/prefutilities.properties; /cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/prefutilities.properties,v <-- prefutilities.properties new revision: 1.22; previous revision: 1.21 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.