1803701 - Clean up the fullscreen browser-chrome test manifest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Ryan VanderMeulen [:RyanVM]]

I was looking at the manifest for the fullscreen browser-chrome tests recently and noticed some potential cleanups. While I was in there, I also took a look at the disabled tests and found some which appear to be stable enough for re-enabling.

Try push:
https://treeherder.mozilla.org/jobs?repo=try&revision=13d8c1792e1e2f4ca6691e130cfec3d16fc07a61

The only oranges there appear to be known intermittents already happening without this patch applied.

That said, it does seem like there could be some state pollution issues with these tests or something. I noticed that browser_fullscreen_enterInUrlbar.js for example didn't often fail itself on Linux/Mac, but led to later tests failing frequently. Have we tried stress testing these tests in verify mode to see if they can be made more reliable?

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1803701 - Clean up the fullscreen browser-chrome test manifest and re-enable some now-passing tests.

Comment 2

[Edgar Chen [:edgar]]

I noticed that browser_fullscreen_enterInUrlbar.js for example didn't often fail itself on Linux/Mac, but led to later tests failing frequently. Have we tried stress testing these tests in verify mode to see if they can be made more reliable?

This test is more about to test url bar, I am not familiar with that. But at a first glance, one potential problem is that the test doesn't restore fullscreen state after test is finished, it might affect subsequent tests, would you mind filing an issue for this? I could try to take a look or test a bit at some point.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06df74ff1c30
Clean up the fullscreen browser-chrome test manifest and re-enable some now-passing tests. r=edgar

Comment 4

[Ryan VanderMeulen [:RyanVM]]

(In reply to Edgar Chen [:edgar] from comment #2)

This test is more about to test url bar, I am not familiar with that. But at a first glance, one potential problem is that the test doesn't restore fullscreen state after test is finished, it might affect subsequent tests, would you mind filing an issue for this? I could try to take a look or test a bit at some point.

I think we can just use bug 1648649 for that investigation.

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/06df74ff1c30