Include paths ending with /**/* limits files shown in searchfox to all subdirectories
Categories
(Conduit :: mots, defect, P2)
Tracking
(Not tracked)
People
(Reporter: davehunt, Unassigned)
Details
Includes that end in /**/* generate links to searchfox that exclude files within the specified directory, and only include files within subdirectories. For example, the following configuration generates a link to tools/rb/**/*, which shows no results. This is because the tools/rb path only contains files and no subdirectories. I'm not sure if the includes is incorrect, or is mots should construct a different link in these cases (simply stripping the **/* suffix would fix it).
- name: 'Core: Code Analysis and Debugging Tools'
description: Tools for debugging Mozilla code or for analyzing speed, memory use,
and other characteristics of it.
includes:
- tools/jprof/**/*
- tools/leak-gauge/**/*
- tools/performance/**/*
- tools/rb/**/*
meta:
group: dev-performance
owners:
- *dbaron
peers: []
machine_name: core_code_analysis_and_debugging_tools
|
||
Comment 1•3 years ago
|
||
On cursory inspection, it appears that searchfox is doing some pattern replacement, and that's possibly what's causing this, though it could also be something else in the search or indexing. tools/rb/**/* is probably being translated to tools/rb/.*/[^/]* which would yield 0 results. mots just uses pathlib.Path.glob and directly parses the input in includes.
mots should probably construct a different searchfox URL, at least for the time being.
Description
•