1803794 - Add max height to dismiss button in Recently Closed tabs in Firefox View

Status: VERIFIED FIXED

(Firefox :: Firefox View, task, P2)

Description

[Kelly Cochrane [:kcochrane]]

Attachment: dismiss-button-too-tall

When a tab title in Recently Closed tabs wraps to a second line, the new dismiss button matches the height of rest of the list item making it appear too tall in these cases. We should add a max-height to the button to prevent this.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1803794 - Align dismiss button of Recently Closed tabs in Fx View to the center to prevent varying height r=sfoster

Comment 2

[Kelly Cochrane [:kcochrane]]

Aligning items of the list item to the center resolved this issue without the need for max-height.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7085edce038
Align dismiss button of Recently Closed tabs in Fx View to the center to prevent varying height r=sfoster

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e7085edce038

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 109.0a1 (2022-12-02) on Windows 10x64.
The issue is verified fixed with Firefox 109.0b2 on Windows 10x64, macOS 11, and Ubuntu 20.04. The hover effect for Dismiss tab button is no longer having a bigger height when a tab URL wraps to multiple lines.