1803795 - Removing cookies from preferences does not work

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Rob Lemley [:rjl]]

Thunderbird 108.0b2

"Accept cookies" is enabled
"Accept 3rd party" is Never

STR:

• open "show cookies" dialog from preferences
• select and remove a cookie either with the dialog button or with the Del key
• observe cookie is removed from list
• close dialog and reopen

expected:

• removed cookies are gone

actual:

• the removed cookies persist
• even after restarting Thunderbird...

Comment 1

[Wayne Mery (:wsmwk)]

Alice, can you identify the regression?

Also fails in nightly 2022-12-03
Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsICookieManager.remove]", result: 2147942487, filename: "chrome://messenger/content/preferences/cookies.js", lineNumber: 781, columnNumber: 0, data: null, stack: "deleteCookie@chrome://messenger/content/preferences/cookies.js:781:24\noncommand@chrome://messenger/content/preferences/cookies.xhtml:1:16\n", location: XPCWrappedNative_NoHelper }

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=3d544985b7296fd45fcd15123e607acf58bc1057&tochange=284f2743822fb496e79f927afcfa23dc4ee7c5cb
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=3d544985b7296fd45fcd15123e607acf58bc1057&tochange=284f2743822fb496e79f927afcfa23dc4ee7c5cb

Suspect:
e70e0a2952b67050a032d989a21a179d58e432a8 Paul Zuehlcke — Bug 1574469 - Removed block param from nsICookieManager::Remove. r=Ehsan

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1803795 - Port bug 1574469: Removed block param from nsICookieManager::Remove. r=#thunderbird-reviewers

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1803795-cookies-beta-ESR.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1574469
User impact if declined: cookies can't be deleted
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

This is the patch inclusive the follow-up.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9306585 [details] [diff] [review]
1803795-cookies-beta-ESR.patch

[Triage Comment]
Approved for beta

Comment 6

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/fa694df6eb94e198ce51e6f304a86968c805c831
https://hg.mozilla.org/comm-central/rev/5b8d5a4afc6b5b49d26210dd01f616ea8cbff1aa

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 108.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/0380d7bc7276
https://hg.mozilla.org/releases/comm-beta/rev/2f020c2692d5

Comment 8

[Rob Lemley [:rjl]]

Verified fixed in Thunderbird 108.0b3.
Additionally, checked cookies.sqlite to make sure the cookies in question were really gone.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9306585 [details] [diff] [review]
1803795-cookies-beta-ESR.patch

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.6.0:
https://hg.mozilla.org/releases/comm-esr102/rev/563cc2baf242