Closed Bug 1803837 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 37279 - Fixing parsing of Oklab and Oklch

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37279 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37279
Details from upstream follow.

Juanmi Huertas <juanmihd@google.com> wrote:

Fixing parsing of Oklab and Oklch

By definition, lab and lch have a lightness value from 0.0 to 100.0, and
both oklab and oklch have a lightness value from 0.0 to 1.0.

Our parser was written in a way that was considering oklab and oklch
values from 0.0 to 100.0.

We are fixing it so it complies with the spec.

This CL also reverts some test that were changed in a previous CL
https://chromium-review.googlesource.com/c/chromium/src/+/4024793

Low-Coverage-Reason: This parser code is tested inside WPT.
Bug: 1393416
Change-Id: I95dc2bc3de20ad916daa72eff260b4b085feeb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4058106
Reviewed-by: Aaron Krajeski \<aaronhk@chromium.org>
Auto-Submit: Juanmi Huertas \<juanmihd@chromium.org>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Juanmi Huertas \<juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078748}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76bf020110b0 [wpt PR 37279] - Fixing parsing of Oklab and Oklch, a=testonly https://hg.mozilla.org/integration/autoland/rev/67cb64226389 [wpt PR 37279] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/76bf020110b0
https://hg.mozilla.org/mozilla-central/rev/67cb64226389

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.