[mailviews] ctrl + a doesn't work after I switch views (focus is in the wrong page?)

VERIFIED FIXED in mozilla1.4alpha

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla1.4alpha
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2])

Attachments

(1 attachment, 1 obsolete attachment)

5.17 KB, patch
(not reading, please use seth@sspitzer.org instead)
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
[mailviews] ctrl + a doesn't work after I switch views (focus is in the wrong page?)

I want to do this:

1) switch to my "junk" view
2) ctrl + a
3) delete

I can't, until I click in the thread pane or folder pane.

it feels like the focus is in the wrong page.

Updated

16 years ago
QA Contact: olgam → laurel

Comment 1

16 years ago
Mail triage team: nsbeta1+/adt2
Keywords: nsbeta1+
Whiteboard: [adt2]
(Assignee)

Comment 2

16 years ago
Created attachment 114094 [details] [diff] [review]
Move cmd_selectAll to the default controller
(Assignee)

Comment 3

16 years ago
Comment on attachment 114094 [details] [diff] [review]
Move cmd_selectAll to the default controller

I remove the thread pane controller completely because it's no longer doing
anything, but you might prefer to comment it out.
Attachment #114094 - Flags: review?(sspitzer)
(Assignee)

Comment 4

16 years ago
Comment on attachment 114094 [details] [diff] [review]
Move cmd_selectAll to the default controller

I just noticed that I deleted the SetFocusThreadPane() call, so the behaviour
when pressing ctrl+a in the folder pane has changed. Let me know what you want
to see in a new patch.
Attachment #114094 - Flags: superreview?(sspitzer)
neil, since we only allow single selection in the folder pane, I think we should
still do a select all of the thread pane when you do control+a and the folder
pane has focus.

ctrl+shift+a should also continue to select the current thread in the thread
pane, if the folder pane has focus.

note, this bug is about ctrl+a not working after I siwtch to junk view and do a
delete.  is the thread pane controller no longer the current controller?

note, this doesn't appear to happen when I do a delete and I'm not in QS.

I'm not sure your patch is the right fix.
Comment on attachment 114094 [details] [diff] [review]
Move cmd_selectAll to the default controller

rejected, since according to neil this breaks the ctrl+a behavior when the
folder pane has focus.

which controller is active after I switch views?  "Edit | Select | All
(Ctrl+A)" is still enabled.

is the default controller being used, because I clicked on the menulist in QS
bar?

keep in mind, ctrl+a should select all text if the QS text bar has focus, and
should select the entire message body if the message pane has focus.
Attachment #114094 - Flags: superreview?(sspitzer)
Attachment #114094 - Flags: superreview-
Attachment #114094 - Flags: review?(sspitzer)
Attachment #114094 - Flags: review-
from a private conversation between neil and I:

> Ctrl+A will still work in the QS bar or the message pane, as they grab 
> cmd_selectAll, but the problem with the folder pane is that it currently 
> transfers focus to the thread pane when you press Ctrl+A, which I assume you 
> still want? 

Yes, I still want that.

> Also, do you have a problem with removing the thread pane controller, and 
> let the default controller do all the work? 

I'm ok with removing it and moving the code to the default controller. 

re-assign to neil.
Assignee: sspitzer → neil
(Assignee)

Comment 8

16 years ago
Created attachment 114424 [details] [diff] [review]
Fix focus issue
(Assignee)

Updated

16 years ago
Attachment #114424 - Flags: review?(sspitzer)
Comment on attachment 114424 [details] [diff] [review]
Fix focus issue

r/sr=sspitzer

thanks neil.
Attachment #114424 - Flags: superreview+
Attachment #114424 - Flags: review?(sspitzer)
Attachment #114424 - Flags: review+
(Assignee)

Updated

16 years ago
Attachment #114094 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Target Milestone: --- → mozilla1.4alpha
(Assignee)

Comment 10

16 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

15 years ago
Using trunk build 20020228 on winxp, macosx and linux this is fixed  Verified
Status: RESOLVED → VERIFIED
QA Contact: laurel → esther

Comment 12

15 years ago
Note, when QS text has been entered, the text does not release the focus,
therefore expected results as mentioned in comment 6 does not happen. I will log
a new bug for the state the QS typing is left in, then I will check the expected
functionality of this bug on it.  

Comment 13

15 years ago
New bug for QS text field selecting the text without user intervention is bug
195793, this bug started with 2-28 trunk builds so this portion of the test will
be tested after it's fixed. 
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.