1803980 - UrlbarValueFormatter generates confusing console logs in tests when resizing window

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Shane Hughes [:aminomancer]]

See here for a frequent example.

The code path for this issue goes like this:

1. The browser test resizes the window, which apparently can happen while the urlbar input is valueless
2. Resizing invokes UrlbarValueFormatter's resize handler
3. This calls _ensureFormattedHostVisible with no metadata argument after 100ms,
4. which calls _getUrlMetaData,
5. which calls Services.uriFixup.getFixupURIInfo (passing the input value, which is undefined at this point),
6. which explicitly throws if no url is passed.
7. Although the exception is technically handled by the trycatch block in _getUrlMetaData, that apparently doesn't prevent it from being logged (I'm assuming but don't actually know if that's expected behavior in general).

Idk exactly why the input value is undefined — looking at the context of the test, it seems like at every point when the window is resized the urlbar input value should be about:firefoxview. But clearly I'm missing something. I thought maybe it was the cleanup function, which does call resizeTo on the window after the Firefox View tab is closed up. But that should happen after the whole test file is finished, which doesn't match with the test logs I've been seeing.

In any case, I think there's a pretty simple fix here to just return before calling Services.uriFixup.getFixupURIInfo if the url is null.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1803980 - Fix urlbar window resize error logs. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb9ac51ccbe5
Fix urlbar window resize error logs. r=adw

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cb9ac51ccbe5