Modernize and clean up desktop capture
Categories
(Core :: WebRTC: Audio/Video, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
(Regressed 1 open bug)
Details
Attachments
(4 files)
DesktopCaptureImpl is an old undeleted libwebrtc class that we forked when it was removed from libwebrtc. To be able to reason better about it (and refactor it easier) and its dependencies we should modernize and clean it up.
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
|
Assignee | |
Comment 3•1 year ago
|
||
This patch moves the bits that need to run on main thread to avoid the deadlock
in bug 1456101 closer to where the deadlock would happen, effectively shortening
them.
It also applies the same strategy to a few more call to the same function, that
happen elsewhere, and therefore should also be prone to deadlocking.
|
|
Assignee | |
Comment 4•1 year ago
|
||
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a44a64816009 Mozify args and members in desktop_capture_impl and modernize/simplify somewhat. r=webrtc-reviewers,bwc https://hg.mozilla.org/integration/autoland/rev/a62ca2f3121f Mozify args and members in desktop_device_info and modernize/simplify somewhat. r=webrtc-reviewers,bwc https://hg.mozilla.org/integration/autoland/rev/41c09904d8c4 Improve TabCapturerWebrtc includes. r=bwc https://hg.mozilla.org/integration/autoland/rev/67f176c3a9ac Move and improve the fix for bug 1456101. r=webrtc-reviewers,ng
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a44a64816009
https://hg.mozilla.org/mozilla-central/rev/a62ca2f3121f
https://hg.mozilla.org/mozilla-central/rev/41c09904d8c4
https://hg.mozilla.org/mozilla-central/rev/67f176c3a9ac
Description
•