1804170 - Intermittent comm/mail/components/extensions/test/browser/browser_ext_browserAction_popup_click.js | This test exceeded the timeout threshold.

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=398725843&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KqYk6n6nQyOgm89u6kY2KQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Intermittent Failures Robot]

4 failures in 3510 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform and build breakdown:

• macosx1015-64-shippable-qr: 1
  • opt: 1
• macosx1015-64-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2022-12-05&endday=2022-12-11&tree=all

Comment 2

[Intermittent Failures Robot]

1 failures in 3558 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2022-12-12&endday=2022-12-18&tree=all

Comment 3

[Intermittent Failures Robot]

1 failures in 3752 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-02-27&endday=2023-03-05&tree=all

Comment 4

[Intermittent Failures Robot]

1 failures in 3966 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-03-06&endday=2023-03-12&tree=all

Comment 5

[Intermittent Failures Robot]

1 failures in 4077 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-05-08&endday=2023-05-14&tree=all

Comment 6

[Intermittent Failures Robot]

1 failures in 3076 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-08-14&endday=2023-08-20&tree=all

Comment 7

[Intermittent Failures Robot]

1 failures in 4018 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-10-02&endday=2023-10-08&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 3484 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-10-16&endday=2023-10-22&tree=all

Comment 9

[Intermittent Failures Robot]

2 failures in 3356 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-10-30&endday=2023-11-05&tree=all

Comment 10

[Intermittent Failures Robot]

2 failures in 3288 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-11-06&endday=2023-11-12&tree=all

Comment 11

[Intermittent Failures Robot]

1 failures in 3671 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• windows11-64-2009-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2023-12-04&endday=2023-12-10&tree=all

Comment 12

[Intermittent Failures Robot]

2 failures in 2274 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2024-01-01&endday=2024-01-07&tree=all

Comment 13

[Intermittent Failures Robot]

2 failures in 3382 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2024-02-19&endday=2024-02-25&tree=all

Comment 14

[Intermittent Failures Robot]

2 failures in 4198 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1804170&startday=2024-03-04&endday=2024-03-10&tree=all

Comment 15

[John Bieling]

Attachment: Bug 1804170 - Unify clicks on menu items and hiding menu popups. r=#thunderbird-reviewers

We know we have issues with clicks on menu items and hiding menu popups
in the WebExtension tests. We currently mitigate these issues not only
in header files, but also directly in tests, and we also still have
places which are not using the mitigation (which could be the reason for
this intermittent).

While I still attempt to find the underlying cause for these issues,
this patch tries to unify the mitigation.

1. Use the helper clickItemInMenuPopup() instead of manually calling
   menu.activateItem() in the tests themselves. The helper waits for the
   "popupHidden" event, which was not waited for in all places.

2. Use the helper closeMenuPopup() instead of manually calling
   `menu.hidePopup() in the tests themselves. The helper waits for the
   "popupHidden" event, which was not waited for in all places.

3. The function closeContextMenu() has been renamed to
   closeBrowserContextMenuPopup() and no longer accepts a menu
   parameter, but is now used only for the browserContext menu. If
   a specific menu should be closed, closeMenuPopup() should be used.

4. The function closeExtensionContextMenu() has been renamed to
   clickItemInBrowserContextMenuPopup(), which better describes what it
   does.

Comment 16

[John Bieling]

Attachment: Bug 1804170 - Properly wait for action popups being closed. r=#thunderbird-reviewers

Another reason why this type of test could fail: We are not waiting till
the popup is closed but use a timeout.

This patch uses the helper closeBrowserAction() in all places,
which waits for the "popuphidden" event.

It also increases readability by using the named event "popup closed".

In the browser_ext_browserAction_popup_focus.js test, the
wait-for-closed logic is moved from the extensions background to the
test itself, because it is much more stable this way.

Depends on D204760

Comment 17

[John Bieling]

Attachment: Bug 1804170 - Remove more timeouts in popup tests. r=#thunderbird-reviewers

This patch removes more arbitrary timeouts.

1. After menu.activateItem() and menu.hidePopup(), wait for an animation
   frame instead of a fixed timeout.

2. No longer wait 1s before closing the popup in the run_popup_test()
   function.

Depends on D204761

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e6e1633e8d80
Unify clicks on menu items and hiding menu popups. r=mkmelin
https://hg.mozilla.org/comm-central/rev/3225ec8e3846
Properly wait for action popups being closed. r=mkmelin