1804213 - Network ID table is included in <a> element

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[6k64x4ma]

Attachment: screenshot.webp

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

1. Go to about:networking#networkid

Actual results:

The table is unnecessarily included in the <a> element linking to about:logging.

Expected results:

This is regressed by Bug 1347955.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:padenot, since you are the author of the regressor, bug 1347955, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1804213 - Close <a> in about:networking#networkid.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa1cdaa8a32c
Close <a> in about:networking#networkid.

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fa1cdaa8a32c

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1347955

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:padenot, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 9306836 [details]
Bug 1804213 - Close <a> in about:networking#networkid.

Beta/Release Uplift Approval Request

• User impact if declined: Bad rendering in about:networking.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Open about:networking#networkid, if this reproduces, the table is a link.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial markup fix.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9306836 [details]
Bug 1804213 - Close <a> in about:networking#networkid.

Switching to Release since there are no more betas for 108 and we are in RC week

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9306836 [details]
Bug 1804213 - Close <a> in about:networking#networkid.

Approved for 108.0rc2

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/5980dd0eef1b

Comment 11

[Emil Ghitta, QA [:emilghitta]]

Reproduced this issue using Firefox 109.0a1 (BuildId:20221206164509) on Windows 10 64bit.

This issue is verified fixed using Firefox 109.0a1 (BuildId:20221209044848) and Firefox 108.0rc2 (BuildId:20221208122842) on Windows 10 64bit, macOS 11 & Ubuntu 22.04