1804232 - Html Preview of network response is broken in console

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[alexander]

Attachment: First blanc render window, Next - html code

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

I make an Ajax request and want to see the result of its execution in the console of the webdeveloper panel.

Actual results:

If the result is with content-type: text/html then I see a white empty window instead of rendering html. Moreover, if you switch to "show code" there is an html code there. There is no rendering.

Expected results:

Before version 107 everything was fine (the result was rendered), now rendering works only on the "Network" tab. There the result is displayed as it should.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Netmonitor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[alexander]

Move to 'DevTools::Console' component, please.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to alexander from comment #2)

Move to 'DevTools::Console' component, please.

The console component showing network requests detail is the same as in the Netmonitor, so this is the right component

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Regressor could be Bug 1640689
Alexander, could you give us a public url where we can check this? if it's not public, maybe you could paste the actual HTML content of the request here so we can reproduce the issue.

Comment 5

[alexander]

No problem, i maked it. Look at http://tst.dimases.ru/ with simple instruction with screenshots...

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

(In reply to alexander from comment #5)

No problem, i maked it. Look at http://tst.dimases.ru/ with simple instruction with screenshots...

Thanks a lot for putting this up.
And sorry, I was wrong, this does only appear in the webconsole, I'll move the bug to the appropriate module

Comment 7

[alexander]

Ok, thanks, I said that it is only in the console =). I'm waiting for a fix, I really need to see the rendering there.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

(In reply to alexander from comment #7)

Ok, thanks, I said that it is only in the console =). I'm waiting for a fix, I really need to see the rendering there.

can't you use the network panel until we fix this?

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

So when we render the HTML preview in the console, we're getting a oop-browser-crashed event, from https://searchfox.org/mozilla-central/rev/70bc66e002ad1cdb1fe5d77428803432f261038a/devtools/client/netmonitor/src/components/previews/HtmlPreview.js#26-33

const iframe = container.ownerDocument.createXULElement("iframe");
this.iframe = iframe;
iframe.setAttribute("type", "content");
iframe.setAttribute("remote", "true");
iframe.addEventListener("mousedown", e => e.preventDefault(), {
  capture: true,
});
container.appendChild(iframe); // triggers the "oop-browser-crashed" event

I'm still not sure what's causing this

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

okay, we probably need to add the console document in https://searchfox.org/mozilla-central/rev/70bc66e002ad1cdb1fe5d77428803432f261038a/dom/base/nsFrameLoader.cpp#2683

"chrome://devtools/content/netmonitor/index.html"_ns,

Comment 11

[alexander]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #8)

can't you use the network panel until we fix this?
I use the network panel, though it's not very convenient. Hope it will be fixed in the next release.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

:ochameau, since you are the author of the regressor, bug 1640689, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

I'm already looking into it
Waiting for TRY result: https://treeherder.mozilla.org/jobs?repo=try&revision=631d9e569bf255d4ff3165e83ccb7b78b7c8051ehttps://treeherder.mozilla.org/jobs?repo=try&revision=631d9e569bf255d4ff3165e83ccb7b78b7c8051e

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1640689

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1804232 - Add webconsole to the whitelist of nested content browsers. r=smaug.

As it was done for the netmonitor in Bug 1640689, we need to add the webconsole
document to the whitelist of nested content browsers so we can show the html
preview of network request in the console.

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1804232 - [devtools] Add test for network request HTML preview in webconsole. r=bomsy.

Depends on D164103

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5f24755764e
Add webconsole to the whitelist of nested content browsers. r=smaug.
https://hg.mozilla.org/integration/autoland/rev/4aec58116226
[devtools] Add test for network request HTML preview in webconsole. r=bomsy.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1640689

Comment 21

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e5f24755764e
https://hg.mozilla.org/mozilla-central/rev/4aec58116226

Comment 22

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9307123 [details]
Bug 1804232 - Add webconsole to the whitelist of nested content browsers. r=smaug.

Beta/Release Uplift Approval Request

• User impact if declined: Users can't see network requests html preview in the console (we had several reports about this already)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): devtools only patch, with automated test (in https://phabricator.services.mozilla.com/D164104), reproducing a change that was made earlier in the netmonitor
• String changes made/needed:
• Is Android affected?: No

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9307123 [details]
Bug 1804232 - Add webconsole to the whitelist of nested content browsers. r=smaug.

Approved for 109.0b3.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/76f4f013cada
https://hg.mozilla.org/releases/mozilla-beta/rev/f35e442943f7