Closed Bug 1804284 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 37355 - VT: Ensure all layers that recalculate their draw props push props too

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37355 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37355
Details from upstream follow.

Vladimir Levin <vmpstr@chromium.org> wrote:

VT: Ensure all layers that recalculate their draw props push props too

This patch is a more comprehensive fix for the referenced bug.
Previously, we've only addressed opacity animations, but the same bug
is present for transform animations as well. The problem with
transforms is that to detect changes in the matrix, we need to do
a lot of float comparisons. It seems better to just unconditionally
say that if we recalculated draw properties, then that layer needs
to push properties as well.

Note for picture layer impls, this is still a no-op, since they
always push their properties.

R=pdr@chromium.org

Bug: 1385432
Change-Id: I6df15e6e344507f26336698e4bf890728690da52
Reviewed-on: https://chromium-review.googlesource.com/4081632
WPT-Export-Revision: ca9b15e9e5130e4c3ec41e57cbf021ef32a02ca6

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f432fa08e2c [wpt PR 37355] - VT: Ensure all layers that recalculate their draw props push props too, a=testonly https://hg.mozilla.org/integration/autoland/rev/7f98cb5b4e59 [wpt PR 37355] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/0f432fa08e2c
https://hg.mozilla.org/mozilla-central/rev/7f98cb5b4e59

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.