[wpt-sync] Sync PR 37369 - Ensure Soft Navigation LCP, FCP and FP fire more than once
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox110 fixed)
Tracking | Status | |
---|---|---|
firefox110 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 37369 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/37369
Details from upstream follow.
Yoav Weiss <yoavweiss@chromium.org> wrote:
Ensure Soft Navigation LCP, FCP and FP fire more than once
There were a couple of issues preventing paint entries from firing after
the first soft navigation is detected:
- The related flags were reset only once.
- Image paint flags were not reset at all.
This CL fixes those two issues.
There's another issue [1] this work revealed, which would wait for a
followup.Bug: 1395507
Change-Id: Ib5aa9f240c7d67f934315a2643ccc022ad4ced72Reviewed-on: https://chromium-review.googlesource.com/4083642
WPT-Export-Revision: a375919e74175f209bf74529bfc08edfbe3d0349
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 24 tests and 1 subtests
Status Summary
Firefox
OK
: 1
PASS
: 1
FAIL
: 1
TIMEOUT
: 34[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 35[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 37[GitHub]
ERROR
: 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 5[GitHub]
Chrome
OK
: 23
PASS
: 6
FAIL
: 17
TIMEOUT
: 2
Safari
TIMEOUT
: 39
ERROR
: 5
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /soft-navigation-heuristics/back.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/dropped-entries.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:PASS
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/hash.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect hashchange event.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect hashchange event.:
- /soft-navigation-heuristics/image-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:PASS
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/image-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/image-lcp-followed-by-two-image-softnavs-lcp.tentative.html [wpt.fyi]:
ERROR
(Chrome:TIMEOUT
, Safari:ERROR
)- Multiple soft navigations get FP, FCP and LCP for each one:
TIMEOUT
(Chrome:TIMEOUT
, Safari:TIMEOUT
)
- Multiple soft navigations get FP, FCP and LCP for each one:
- /soft-navigation-heuristics/navigate-child.html [wpt.fyi]
- Test that a navigated child window doesn't crash:
FAIL
[Gecko-linux1804-64-qr-debug
,Gecko-linux1804-64-qr-opt
,Gecko-windows10-32-2004-qr-debug
,Gecko-windows10-32-2004-qr-opt
,Gecko-windows10-64-2004-qr-debug
,Gecko-windows10-64-2004-qr-opt
,GitHub
],PASS
[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview
,Gecko-android-em-7.0-x86_64-qr-debug-geckoview
,Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview
,Gecko-android-em-7.0-x86_64-qr-opt-geckoview
] (Chrome:PASS
, Safari:TIMEOUT
)
- Test that a navigated child window doesn't crash:
- /soft-navigation-heuristics/navigation-api-hash.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Test soft navigation with the Navigation API:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Test soft navigation with the Navigation API:
- /soft-navigation-heuristics/navigation-api-preventDefault.tentative.html [wpt.fyi]:
ERROR
[GitHub
],TIMEOUT
[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview
,Gecko-android-em-7.0-x86_64-qr-debug-geckoview
,Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview
,Gecko-android-em-7.0-x86_64-qr-opt-geckoview
,Gecko-linux1804-64-qr-debug
,Gecko-linux1804-64-qr-opt
,Gecko-windows10-32-2004-qr-debug
,Gecko-windows10-32-2004-qr-opt
,Gecko-windows10-64-2004-qr-debug
,Gecko-windows10-64-2004-qr-opt
] (Chrome:OK
, Safari:ERROR
)- Aborted navigate event is not a soft navigation:
TIMEOUT
(Chrome:PASS
)
- Aborted navigate event is not a soft navigation:
- /soft-navigation-heuristics/navigation-api-rejected.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Test intercepted and rejected navigate event:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Test intercepted and rejected navigate event:
- /soft-navigation-heuristics/navigation-api.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Test soft navigation with the Navigation API:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Test soft navigation with the Navigation API:
- /soft-navigation-heuristics/popstate.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- A soft navigation that uses a same-document initiated popstate event is recognized by SoftNavigationHeuristics:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- A soft navigation that uses a same-document initiated popstate event is recognized by SoftNavigationHeuristics:
- /soft-navigation-heuristics/soft-navigation-detection-main-descendent.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect soft navigation adding content to a main descendent.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect soft navigation adding content to a main descendent.:
- /soft-navigation-heuristics/soft-navigation-detection-non-main.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/soft-navigation-detection-web-component-lifecycle.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/soft-navigation-detection.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:PASS
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/soft-navigation-no-url.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
- Test that a soft navigation is not detected when a URL is not passed to the history API.:
TIMEOUT
(Chrome:PASS
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/text-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/text-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect simple soft navigation.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect simple soft navigation.:
- /soft-navigation-heuristics/navigation-api-back.tentative.html [wpt.fyi]:
ERROR
(Chrome:OK
, Safari:ERROR
) - /soft-navigation-heuristics/navigation-api-forward.tentative.html [wpt.fyi]:
ERROR
(Chrome:OK
, Safari:ERROR
) - /soft-navigation-heuristics/navigation-api-traverseto.tentative.html [wpt.fyi]:
ERROR
(Chrome:OK
, Safari:ERROR
) - /soft-navigation-heuristics/replacestate-null-then-push.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect soft navigation with replaceState that has a null URL, then
pushState with the URL.:TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect soft navigation with replaceState that has a null URL, then
- /soft-navigation-heuristics/replacestate.tentative.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:TIMEOUT
)- Detect soft navigation with replaceState.:
TIMEOUT
(Chrome:FAIL
, Safari:TIMEOUT
)
- Detect soft navigation with replaceState.:
Comment 4•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/178a1c66f2b9
https://hg.mozilla.org/mozilla-central/rev/14b243a7e80a
Description
•