Open
Bug 1804553
Opened 2 years ago
Make content of a selected inline comment readable on Dark theme in Phab
Categories
(Conduit :: Phabricator, defect)
Conduit
Phabricator
Tracking
(Not tracked)
NEW
People
(Reporter: ayeddi, Unassigned)
Details
Attachments
(1 file)
185.53 KB,
image/png
|
Details |
When an inline comment is selected, the text is not readable while on Dark theme. One has to highlight the text to be able to read it.
Consider adding the following style to the differential.pkg.css
:
.inline-comment-selected .inline-comment-element {
background: SelectedItem;
color: SelectedItemText;
}
or keep the comment body unchanged but the header highlighted, for instance:
.inline-comment-selected .inline-comment-element
.differential-inline-comment-head {
background: SelectedItem;
border-color: SelectedItemText;
}
The SelectedItem
is part of the High Contrast Mode, if this is not possible to use, reusing the blue from the .inline-hover
color for the background with black foreground would look in style with the other parts of the UI.
You need to log in
before you can comment on or make changes to this bug.
Description
•