Closed Bug 1804573 Opened 1 year ago Closed 1 year ago

[scroll-animations-1] `scroll-timeline` and `view-timeline` shorthand syntax

Categories

(Core :: Layout, defect)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: mozilla-apprentice, Assigned: boris)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

A resolution was made for csswg-drafts/#7627.

[scroll-animations-1] `scroll-timeline` and `view-timeline` shorthand syntax

  • RESOLVED: Have parsing with fixed order of name and axis

Discussion.

Keywords: dev-doc-needed
Assignee: nobody → boris.chiou

The syntax of scroll-timeline shorthand is:
[ <'scroll-timeline-name'> <'scroll-timeline-axis'>? ]#.

The order of name and axis is fixed. This patch just updates WPT to
match the spec. The fix of Gecko will be together with Bug 1809005.

Note: The WPT of view-timeline shorthand is correct, so no need to change it.

Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4cd86d3d1bb7
Update scroll-timeline shorthand syntax in WPT. r=emilio
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Looks like Chrome uploaded this: https://github.com/web-platform-tests/wpt/commit/86e1bdee928a40b1589b05ad20f7500f2d7a0da2. However, that wpt patch has typos. It should use scroll-timeline, instead of view-timeline. So I think it's fine to just override the conflict with my patch.

See comment 4 for the solution of this conflict.

Flags: needinfo?(james)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38220 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(james)

Thanks for the information on how to resolve the conflict! :)

Hello Boris, I am updating the MDN docs for these properties.

With the shorthand property scroll-timeline now available by default, is it correct to assume that the long hand properties, scroll-timeline-name and scroll-timeline-axis will also not need to be set behind a preference? Also, scroll-timeline is not yet supported on android, correct?

Could you help to confirm if view-timeline shorthand property or any of its longhand properties are yet supported in Firefox? I see them on searchfox but not sure if they've been implemented. Thanks!

Flags: needinfo?(boris.chiou)

Thanks for udpating the MDN docs for scroll-timeline.

(In reply to Dipika from comment #10)

Hello Boris, I am updating the MDN docs for these properties.

With the shorthand property scroll-timeline now available by default, is it correct to assume that the long hand properties, scroll-timeline-name and scroll-timeline-axis will also not need to be set behind a preference? Also, scroll-timeline is not yet supported on android, correct?

scroll-timeline shorthand and scroll-timeline-name & scroll-timeline-axis longhands are all behind the pref, layout.css.scroll-driven-animations.enabled. And the pref is disabled by default. So they should not be available by default in all channels.
However, it's still possible to test them by enabling the pref of course. :)

Could you help to confirm if view-timeline shorthand property or any of its longhand properties are yet supported in Firefox? I see them on searchfox but not sure if they've been implemented. Thanks!

Yes, we support these properties, view-timeline shorthand and its longhand properties

However, there is no rendering result for view-timeline and its longhand propertis because I'm still working on it. See Bug 1737920.

Flags: needinfo?(boris.chiou)

Thank you!

Doc updates on MDN can be tracked via https://github.com/mdn/content/issues/24396

You need to log in before you can comment on or make changes to this bug.