1804728 - Improve UI/UX to match mocks

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, enhancement, P3)

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1804728, part 1 - Fetch all identity provider manifests before showing the identity provider chooser, r=timhuang!,#webidl!

This is required to make our Identity Provider chooser pretty.
This has minimal privacy impact because these requests are not credentialed.
I had to re-define the service for prompts to include these manifests and return indexes into argument arrays, rather than elements of those arrays.

Also updating sourcedocs to reflect this new order of calls.

Depends on D168812

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1804728, part 2 - Add the picture field to the IdentityAccount information, r=#webidl!

Depends on D168813

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1804728, part 3 - Clean up close popup codepaths - r=timhuang!

Depends on D168814

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1804728, part 4 - Make UI match mock, without pictures - r=pbz!

Depends on D168815

Comment 5

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1804728, part 5 - Add dynamic pictures to the UI - r=pbz!

Depends on D168817

Comment 6

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1804728, part 6 - Add more comments on the IdentityCredentialPromptService, r=pbz!

Depends on D168818

Comment 7

[Benjamin VanderSloot [:bvandersloot]]

I'm going to note here that this isn't the last step of UI improvement. We need to finalize color and theming in bug 1814936.

Comment 8

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1804728, part 7 - Bring IDL up to date with spec and reduce UTF-16 vs UTF-8 conversions - r=emilio!

Depends on D168819

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa974f0e09cf
part 1 - Fetch all identity provider manifests before showing the identity provider chooser, r=timhuang,emilio
https://hg.mozilla.org/integration/autoland/rev/7c004264b306
part 2 - Add the picture field to the IdentityAccount information, r=emilio
https://hg.mozilla.org/integration/autoland/rev/ed2b96f130ad
part 3 - Clean up close popup codepaths - r=timhuang
https://hg.mozilla.org/integration/autoland/rev/d62ca666e600
part 4 - Make UI match mock, without pictures - r=pbz,desktop-theme-reviewers,flod,Itiel
https://hg.mozilla.org/integration/autoland/rev/9a48ce7c8bcf
part 5 - Add dynamic pictures to the UI - r=pbz
https://hg.mozilla.org/integration/autoland/rev/cc4d91693c3c
part 6 - Add more comments on the IdentityCredentialPromptService, r=pbz
https://hg.mozilla.org/integration/autoland/rev/acfc9c89c8d7
part 7 - Bring IDL up to date with spec and reduce UTF-16 vs UTF-8 conversions - r=emilio

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/fa974f0e09cf
https://hg.mozilla.org/mozilla-central/rev/7c004264b306
https://hg.mozilla.org/mozilla-central/rev/ed2b96f130ad
https://hg.mozilla.org/mozilla-central/rev/d62ca666e600
https://hg.mozilla.org/mozilla-central/rev/9a48ce7c8bcf
https://hg.mozilla.org/mozilla-central/rev/cc4d91693c3c
https://hg.mozilla.org/mozilla-central/rev/acfc9c89c8d7