1804745 - [wpt-sync] Sync PR 37409 - Miss the cache when breaking before a fragment with low break appeal.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37409 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37409
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Miss the cache when breaking before a fragment with low break appeal.

If a fragment doesn't fit in the fragmentainer, we should of course
break before it. This normally happens automatically, but in some cases
the machinery needs an extra nudge. FinishFragmentation() will in some
cases clamp the break (inside) appeal down to kBreakAppealLastResort.
We need to miss the cache if we find such layout results in the cache,
since the break appeal may no longer be valid, when we have moved over
to a new fragmentainer. Otherwise we will never let the node fit in the
previous fragmentainer, not even after making the fragmentainers taller.
This leads to correctness issues, and also freezes during column
balancing, since no fragmentainer stretch amount will be enough to pull
the node back to the first fragmentainer.

Bug: 1395408, 1399449
Change-Id: Ic0fc032b0b7022dfb9e5c35af75e09d8b3f50316
Reviewed-on: https://chromium-review.googlesource.com/4085506
WPT-Export-Revision: 651ea9ef652e1893e8193413f8f4635fac8615db

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=352bbb04f6ec6e6c0f9a156ec1048f8658250975

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c55ee3b19b3ba7c21e9d5cf27221f2dd91031003

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS : 4

Chrome

FAIL : 2
TIMEOUT: 2

Safari

PASS : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3f9f89a5773
[wpt PR 37409] - Miss the cache when breaking before a fragment with low break appeal., a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c3f9f89a5773