nsIFrame::GetStartPageValue/nsIFrame::GetEndPageValue are slow with very large page counts with CSS named pages enabled
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox109 | --- | fixed |
People
(Reporter: alaskanemily, Assigned: alaskanemily)
References
Details
Attachments
(1 file)
This is the same underlying problem as Bug 1803861. We can fix this by copying over the PageValuesProperty frame property when creating continuations.
We might want to investigate sharing a single PageValues struct for all continuations, or ref-counting the struct and possibly also sharing it for entire subtrees as a followup.
|
Assignee | |
Comment 1•1 year ago
|
||
This was causing layout/generic/crashtests/1683126.html to timeout with named
pages enabled.
It is possible for a frame's PageValues struct to have both the start and end
values be set to null as further children are added. In that case, we can
avoid doing an extra allocation for each of that frame's continuations, as a
small optimization.
|
||
Updated•1 year ago
|
Pushed by emcdonough@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4af3a83487c7 Make nsIFrame::GetStartPageValue/nsIFrame::GetEndPageValue constant complexity by copying over the PageValuesProperty value when creating frame continuations. r=dholbert
|
||
Comment 3•1 year ago
|
||
Backed out for causing build bustages at nsCSSFrameConstructor.cpp.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a70682a5774d93c9f14f858736e9df1beed89b85
Failure log: https://treeherder.mozilla.org/logviewer?job_id=399077276&repo=autoland&lineNumber=22325
Pushed by emcdonough@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2fdd07b21f5 Make nsIFrame::GetStartPageValue/nsIFrame::GetEndPageValue constant complexity by copying over the PageValuesProperty value when creating frame continuations. r=dholbert
|
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•1 year ago
|
Description
•