Closed Bug 1804795 Opened 3 years ago Closed 2 years ago

Add Glean equivalent for legacy telemetry reach/impression/exposure event used by Nimbus

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: nalexander, Assigned: dmosedale)

References

(Blocks 1 open bug)

Details

I went to implement Bug 1790448 only to discover that the relevant reach/impression/exposure event is reported only by legacy Telemetry and not by Glean. This ticket tracks adding the Glean equivalent in _ASRouter._recordReachEvent.

But perhaps these reach events are already covered by the Glean exposure event in ASRouter.jsm? I believe these are distinct concepts but this isn't my area of expertise.

Travis or Barret: could one of you teach me the difference between reach and exposure, if there is one? And could one of you make this ticket happen?

Flags: needinfo?(tlong)
Flags: needinfo?(brennie)
Component: Background Tasks → Nimbus Desktop Client
Product: Toolkit → Firefox

I can't say that I know anything about these "reach" events, but they appear to be very similar to the exposure events aside from exposure events only being recorded for nonReachMessages in ASRouter, so I don't think that they are already covered by the Glean events there.

We can certainly add this event to Glean if needed. What is your time frame for needing this? I'm a bit covered up for the next couple of weeks but could probably get to it before the end of the year.

Flags: needinfo?(tlong)

A reach event is an event for an unenrolled branch that says "if i were enrolled in this branch, i would have sent an exposure for this message."

Given a messaging experiment with two branches, control and treatment, the message in each branch will have a trigger. Whenever we hit a trigger, we check all the branches we are NOT enrolled in. If any of the messages in the unenrolled branches match the trigger, we will send a reach event.

Its set up in ASRoutere here. For each branch we aren't enrolled in, we add an extra experiment message with the key forReachEvent.

Reach events get sent here

Flags: needinfo?(brennie)

The severity field is not set for this bug.
:barret, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(brennie)
Severity: -- → S3
Flags: needinfo?(brennie)
Priority: -- → P3

Reach events are part of the messaging system. Kicking this into the fxms triage queue.

Severity: S3 → --
Component: Nimbus Desktop Client → Messaging System
Priority: P3 → --

Dan to triage this bug and decide on a plan.

Assignee: nobody → dmosedale
Status: NEW → ASSIGNED
Priority: -- → P1
Severity: -- → S3

Nick, I'm guessing that the motivation to do this is to make analysis easier by avoiding having to find the other data and then join it. Is that correct?

Flags: needinfo?(nalexander)

(In reply to Dan Mosedale (:dmosedale, :dmose) from comment #7)

Nick, I'm guessing that the motivation to do this is to make analysis easier by avoiding having to find the other data and then join it. Is that correct?

Sorry for the late reply, but I believe all of these events are now Glean-y and this can be closed.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(nalexander)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.