1804810 - [wpt-sync] Sync PR 37416 - Revert "Use direct compositing for canvases rendered on the CPU"

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37416 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37416
Details from upstream follow.

Keishi Hattori <[e-mail]> wrote:

Revert "Use direct compositing for canvases rendered on the CPU"

This reverts commit c6b115aecd3b02b953bcdbffd5884910c25a6a69.

Reason for revert: fast/canvas/canvas-incremental-repaint.html is failing on Mac12 Tests
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/4657/overview

Original change's description:

Use direct compositing for canvases rendered on the CPU

Before this CL, we already had the plumbing for presenting CPU-rendered canvases via GpuMemoryBuffer for direct compositing. That code path was originally implemented to support LowLatency mode. With this change, we exercise the GpuMemoryBuffer code path for "regular" latency canvases. This accelerates compositing, especially for pages that have many canvases.

With this change, MotionMark Images test runs significantly faster, especially with angle/metal enabled.

Bug:1363627

Change-Id: I25b9e3105773fee84a1fc88432ed6640dac4c976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4081383
Commit-Queue: Justin Novosad \<[e-mail]>
Reviewed-by: Juanmi Huertas \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1080998}

Bug: 1363627
Change-Id: Idb59c9044dcc584db332a18a28312e1f4332d14e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4090966
WPT-Export-Revision: ac3275ba7432c735c5e928da735120ecaf0fbee3

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a45ffb12730777e597c8fafb8884f155f83684e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=54f7e9992ab004f66a1a5eca37a1d550fe6c1ec4

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

PASS: 4

Safari

PASS: 4

Links

GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dbe6e0a5e9a
[wpt PR 37416] - Revert "Use direct compositing for canvases rendered on the CPU", a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4dbe6e0a5e9a