1804838 - onBackgroundBrowserCrash throws when called with an iframe

Status: NEW

(Toolkit :: Crash Reporting, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Make sure Bug 1804232 isn't fixed (or revert the patch that fixes it)
2. Open the console, and make sure to have the "Requests" filter turned on
3. Reload the page
4. Expand the network request for the document
5. Select the "Response" panel

Result

At the moment, the remote iframe we're using for the HTML preview crashes (as the console document is not whitelisted in https://searchfox.org/mozilla-central/rev/70bc66e002ad1cdb1fe5d77428803432f261038a/dom/base/nsFrameLoader.cpp#2683) and I can see the following error in the Browser Console:

Uncaught TypeError: browser.getTabBrowser is not a function
    onBackgroundBrowserCrash resource:///modules/ContentCrashHandlers.jsm:300
    onTabCrashed chrome://browser/content/tabbrowser.js:6044

on https://searchfox.org/mozilla-central/rev/196b6aa0427f38058fd43ac90ee94fcf2f436fb6/browser/modules/ContentCrashHandlers.jsm#300 , coming from https://searchfox.org/mozilla-central/rev/196b6aa0427f38058fd43ac90ee94fcf2f436fb6/browser/base/content/tabbrowser.js#6044-6047

The issue probably is that onBackgroundBrowserCrash expects a browser, while here we're passing an iframe. Maybe onSubFrameCrash should be called in such case? I really don't know this part of the code, so I can't really tell.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.